some cleanup (join-path) and a few tweaks to get this to work on OSX …

dfinke / InstallModuleFromGitHub

Install PowerShell Modules from GitHub

Apache License 2.0

87 stars 31 forks source link

some cleanup (join-path) and a few tweaks to get this to work on OSX … #4

Closed jgigler closed 7 years ago

jgigler commented 7 years ago

…and Linux.

dfinke commented 7 years ago

Thanks for the PR. I don't like spaces around my = :)

kidding

I prefer RoboCopy. Join-Path is nice, don't like extra call over the straight string concatenation.

Are you suggesting replacing RoboCopy because this may be run on Linux|Mac?

jgigler commented 7 years ago

Yeah, the changes were to get it to work on OSX and Linux. OSX was barfing with the "\" on the string concatenation, and obviously robocopy is a limitation as well. I guess I could do a switch on $IsLinux / $IsOSX, but IMO it's nice not needing to branch the copy logic.

dfinke commented 7 years ago

Thanks for tracking that down and doing the PR. Much appreciated.