New tests, bug fixes, random++

briantist commented 5 years ago

Add tests for reported and discovered bugs
Add -SetSeed parameter to Invoke-Generate to aid in repeatable runs (for tests mostly)
Align randomdate generator to use Get-Random so that it inherits a set seed
Fix #27 (literal spaces aren't processed properly)
Fix #28 (arguments with spaces fail even when specified properly)
Verstion 2.1.1

dfinke commented 5 years ago

Well, the challenge is, this grew organically, no tests from the outset. This will probably become a Whac-A-Mole problem.

I don't know if these bugs existed before the new changes?

briantist commented 5 years ago

@dfinke yeah I think as we add new functionality, some existing bugs that weren't likely to be exposed are seeing the light. Of the 2 bugs fixed in this PR only #27 is a regression.

Also hoping as we add new tests and get better at adding tests beforehand, we'll be able to prevent regressions and new bugs before they land.

The -SetSeed parameter here helps in writing some tests by being able to get consistent output that can be compared for equality (you can see it used in some of the new tests), so this should lead to a boon of new tests that would have been difficult before. 🎉 to learning from mistakes!

dfinke / NameIT

New tests, bug fixes, random++ #31