search

dfinke / PowerShellHumanizer

PowerShell Humanizer wraps Humanizer: meets all your .NET needs for manipulating and displaying strings, enums, dates, times, timespans, numbers and quantities
Apache License 2.0
121 stars 18 forks source link

Improve custom Type member scripts #5

Closed cdhunt closed 8 years ago

cdhunt commented 8 years ago
dfinke commented 8 years ago

Cool, so you want to move the registering from the psm1 out to the ps1xml? Nice catch on the spelling ;-)

cdhunt commented 8 years ago

That seems like the correct place and breaking up the module makes it easier to collaborate on.

dfinke commented 8 years ago

Makes sense!

cdhunt commented 8 years ago

How should we handle custom properties that call parameter-less methods.

For example, should the implementation of Dehumanize() be a ScriptProperty named Dehumanize or Dehumanized or should it be a ScriptMethod to match the source and be Dehumanize()?

cdhunt commented 8 years ago

I've pushed up type files that cover the existing custom types to the branch Feature_TypeFiles. It broke one of the cmdlets.

dfinke commented 8 years ago

Thanks. I need to look at the PRs in my import excel this weekend. Which did it break? It'd be cool to merge this

cdhunt commented 8 years ago

It was ConvertTo-HyphenatedString. I just fixed that. Need to update the docs then it should be ready for merging.

cdhunt commented 8 years ago

ETS scripts have been moved to ps1xml files with some minor improvements.