search

dfischer / meteor-phantomjs

NPM wrapper for phantom js (works with modulus.io) Fork of https://github.com/gadicc/meteor-phantomjs/blob/master/package.js without sun package
9 stars 6 forks source link

Fix for Meteor v1.0 #4

Closed bstocks closed 10 years ago

bstocks commented 10 years ago

Hi @dfischer - I had to make these changes in order to successfully deploy to modulus while running meteor v1.0

dfischer commented 10 years ago

:+1: thanks.

bstocks commented 10 years ago

Sure thing. Thank you for the package! As soon as this fix hits atmosphere, I'll be adding it to about 8 production sites/apps that live on modulus.

dfischer commented 10 years ago

Glad I can start something helpful. :)

I noticed spiderable crashing a lot so I made this: https://github.com/dfischer/meteor-prerenderio

Let me know if you decide to use that instead. I'm having great success with it. It costs money but oh well.

bstocks commented 10 years ago

Interesting, I'll check that out. Thanks.

Question: I've never published a package to Atmosphere myself, how long should I expect it to take before these changes get up to the Atmosphere server?

dfischer commented 10 years ago

I already pushed the changes. If you check atmosphere it should reflect that. But maybe there needs to be a version bump? It's not updated yet? 

—Daniel Fischer

http://www.danielfischer.com

http://www.twitter.com/dfischer

http://www.github.com/dfischer

On Wed, Oct 29, 2014 at 5:46 PM, Ben Stocks notifications@github.com wrote:

Interesting, I'll check that out. Thanks.

Question: I've never published a package to Atmosphere myself, how long should I expect it to take before these changes get up to the Atmosphere server?

Reply to this email directly or view it on GitHub: https://github.com/dfischer/meteor-phantomjs/pull/4#issuecomment-61029848

bstocks commented 10 years ago

Ah, right you are. Not sure what happened the first time, but it's working now. Thanks!