dfischer / meteor-prerenderio

A meteor wrapper for https://prerender.io/
56 stars 9 forks source link

Cannot add this package to my project #22

Closed ksendra closed 8 years ago

ksendra commented 8 years ago

Hi,

i'm trying to add this package to my meteor app, but keep getting this error:

Error: ENOENT, open 'C:\Users\KSEND_~1\AppData\Local\Temp\mt-1td10o1\os\dfi scher:prerenderio.js' at Object.Future.wait (C:\Users\ksend_000\AppData\Local\.meteor\package s\meteor-tool\1.1.10\mt-os.windows.x86_32\dev_bundle\lib\node_modules\fiber s\future.js:398:15)

Adding other packages works fine. Meteor version is 1.2.1.

What can be wrong?

matthieuh commented 8 years ago

I have the same issue, a windows problem. I'm trying to resolve it.

cricku commented 8 years ago

Same problem here, no fix until now. Below you can see my error messages:

`=> Started proxy. => Started MongoDB.

C:\Users\Cricku\AppData\Local.meteor\packages\meteor-tool\1.1.10\mt-os.windows. x86_32\dev_bundle\lib\node_modules\fibers\future.js:278 throw(ex); ^ Error: ENOENT, open 'C:\Users\Cricku\AppData\Local\Temp\mt-17kalp5\os\dfischer:p rerenderio.js' at Object.Future.wait (C:\Users\Cricku\AppData\Local.meteor\packages\meteor -tool\1.1.10\mt-os.windows.x86_32\dev_bundle\lib\node_modules\fibers\future.js:3 98:15) at C:\tools\fs\files.js:1331:28 at Object.wrapper as open at Object.files.readBufferWithLengthAndOffset (C:\tools\fs\files.js:1474:20)

at C:\tools\isobuild\isopack.js:984:26
at Array.forEach (native)
at Function._.each._.forEach (C:\Users\Cricku\AppData\Local\.meteor\packages

\meteor-tool\1.1.10\mt-os.windows.x86_32\dev_bundle\lib\nodemodules\underscore\ underscore.js:79:11) at C:\tools\isobuild\isopack.js:982:9 at Array.forEach (native) at Function..each._.forEach (C:\Users\Cricku\AppData\Local.meteor\packages \meteor-tool\1.1.10\mt-os.windows.x86_32\dev_bundle\lib\nodemodules\underscore\ underscore.js:79:11) at [object Object]..extend.loadUnibuildsFromPath (C:\tools\isobuild\isopac k.js:942:7) at C:\tools\packaging\tropohouse.js:500:19 at Array.forEach (native) at Function..each._.forEach (C:\Users\Cricku\AppData\Local.meteor\packages \meteor-tool\1.1.10\mt-os.windows.x86_32\dev_bundle\lib\nodemodules\underscore\ underscore.js:79:11) at C:\tools\packaging\tropohouse.js:499:11 at C:\tools\utils\buildmessage.js:356:18 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:349:34 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:347:23 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at Object.enterJob (C:\tools\utils\buildmessage.js:321:26) at Object.download (C:\tools\packaging\tropohouse.js:437:20) at C:\tools\packaging\tropohouse.js:575:22 at C:\tools\utils\buildmessage.js:356:18 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:349:34 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:347:23 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at Object.enterJob (C:\tools\utils\buildmessage.js:321:26) at [object Object]..extend.downloadPackagesMissingFromMap (C:\tools\packagi ng\tropohouse.js:572:20) at C:\tools\project-context.js:702:25 at C:\tools\utils\buildmessage.js:356:18 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:349:34 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:347:23 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at Object.enterJob (C:\tools\utils\buildmessage.js:321:26) at C:\tools\project-context.js:701:20 at C:\tools\packaging\catalog\catalog.js:100:5 at C:\tools\utils\buildmessage.js:268:13 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:261:29 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:259:18 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:250:23 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at Object.capture (C:\tools\utils\buildmessage.js:249:19) at Object.catalog.runAndRetryWithRefreshIfHelpful (C:\tools\packaging\catalo g\catalog.js:99:31) at ProjectContext..extend.downloadMissingPackages (C:\tools\project-contex t.js:700:13) at C:\tools\project-context.js:257:35 at C:\tools\utils\buildmessage.js:356:18 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:349:34 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:347:23 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at Object.enterJob (C:\tools\utils\buildmessage.js:321:26) at ProjectContext._.extend.completeStagesThrough (C:\tools\project-context. js:247:18) at ProjectContext..extend.saveChangedMetadata (C:\tools\project-context.js: 235:10) at ProjectContext..extend.prepareProjectForBuild (C:\tools\project-context. js:240:10) at C:\tools\runners\run-app.js:517:29 at C:\tools\utils\buildmessage.js:268:13 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:261:29 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:259:18 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at C:\tools\utils\buildmessage.js:250:23 at [object Object]..extend.withValue (C:\tools\utils\fiber-helpers.js:114:1 4) at Object.capture (C:\tools\utils\buildmessage.js:249:19) at bundleApp (C:\tools\runners\run-app.js:516:31) at [object Object]..extend.runOnce (C:\tools\runners\run-app.js:594:35) at [object Object]..extend._fiber (C:\tools\runners\run-app.js:858:28) at C:\tools\runners\run-app.js:396:12

dfischer commented 8 years ago

Not able to test on Windows, my apologies.

rynti commented 8 years ago

It appears the issue is that the files have colons in their names (for instance dfisher:prerenderio.js), which is not supported on Windows. However, this can very easily be fixed by simply replacing the colon with an underscore or other compatible character.

A fix would be really appreciated @dfischer :)

dfischer commented 8 years ago

Feel free to open PR @rynti sounds easy enough (currently traveling, but happy to test quickly with a PR)

rynti commented 8 years ago

25 looks great! @dfischer have you had a chance to look at it?

dfischer commented 8 years ago

@rynti merging now

cricku commented 8 years ago

@dfischer thanks, now it's working great on Windows.