Feature/model tests getter setter

ebersold commented 9 years ago

Tests for non-trivial getters and setters of model classes.

wherget commented 9 years ago

Should we be using Hamcrest matchers instead of TestNG Asserts for consistency reasons? Also I'm thinking of wanting to know how good the branch coverage for these tests is...

wherget commented 9 years ago

Okay, I've checked coverage locally, the following points are still open for testing:

[x] PrefabSet.isChildOf is also true for grandchildren
[x] SceneNode.isChildOf is also true for grandchildren
[x] Trying Project.addScenario(null) should throw
[x] Project.addScenario of a Scenario that is currently part of another Project should reparent.
[x] Project.removeScenario of a Scenario that is currently part of this Project should set that scenario's Project to null.

€dit: updated with results of coverage test after checking both branches combined as per @spidan's comment

spidan commented 9 years ago

The tests for adding scenarios to or removing them from projects are already implemented on the more general feature/model-tests branch.

wherget commented 9 years ago

Should be good now. I was debating whether the parent-sibling case should be a separate test case, but there is such a thing as overdoing it.

dfki-asr / compass

Feature/model tests getter setter #18