search

dfki-ric-underactuated-lab / double_pendulum

Dual purpose Acrobot and Pendubot Platform
BSD 3-Clause "New" or "Revised" License
33 stars 22 forks source link

Truncated and Terminated seem to be inverted #5

Closed theovincent closed 1 year ago

theovincent commented 1 year ago

Here, 'truncated' is always set to 'False', however you seem to truncate the episode when the number of step count has reached a limit: https://github.com/dfki-ric-underactuated-lab/double_pendulum/blob/ac80d646ed1f72c4d59670e1a9967ef2a480afcb/src/python/double_pendulum/simulation/gym_env.py#L36-L39

fwiebe commented 1 year ago

Yes, you are right. Thanks for pointing it out! Fixed in 3db4524bd4c00b5bc5f2192c4a909b42346b042c