search

dfki-ric / docker_image_development

Scritps and Dockerfiles to support docker-based, 3D accelerated development and release of docker images
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

auto-add --privileged where needed with warning #81

Closed planthaber closed 1 year ago

planthaber commented 1 year ago

Check if --privileged is already set before auto-adding it with a warning for docker and X (without 3d acceleration)

0Nel commented 1 year ago

Now this has been merged already.. However I personally don't think adding --privileged automatically is a good idea. Is this only to get X apps running? I would just look for privileged and print a user info/warning, if it is not there. Also, does this consider x11 mounts vs. xpra? Running xpra with automatic privilege does not sound like a save procedure.

planthaber commented 1 year ago

There is no way around --privileged when the docker option is needed, but for x11 you are right, a warning should be enough

planthaber commented 1 year ago

https://github.com/dfki-ric/docker_image_development/commit/4ca4a18bb1f317384f54e78aed2365d44ac08e39