search

dfki-ric / movement_primitives

Dynamical movement primitives (DMPs), probabilistic movement primitives (ProMPs), and spatially coupled bimanual DMPs for imitation learning.
https://dfki-ric.github.io/movement_primitives
Other
143 stars 39 forks source link

JOSS suggestion: Statement of need #45

Open gautam-sharma1 opened 1 week ago

gautam-sharma1 commented 1 week ago

After reading the draft, I got a sense that movement_primitives does claim to be faster than other repos in the same space. If that's the case, then it will be good to add that to the "Statement of Need".

Also, is there any way I can reproduce the results?

AlexanderFabisch commented 1 week ago

After reading the draft, I got a sense that movement_primitives does claim to be faster than other repos in the same space. If that's the case, then it will be good to add that to the "Statement of Need".

It is fast for Python, but dmpbbo in C++ is faster for most cases with few dimensions. In high-dimensional cases this library seems to be better than dmpbbo though. So I don't know if I can claim this as an advantage of this library over others. In the summary I mention that Cython is used to speed up online execution. What do you think?

Also, is there any way I can reproduce the results?

I just uploaded most of the benchmark code to this gist: https://gist.github.com/AlexanderFabisch/a69534fe425d305d7550eb526825cf2f

The C++ code for dmpbbo is currently missing though. I'll need some time to recover it.