add ability to hide label indicator

dfki-ric / pytransform3d

3D transformations for Python.

https://dfki-ric.github.io/pytransform3d/

Other

619 stars 65 forks source link

add ability to hide label indicator #172

Closed alek5k closed 2 years ago

alek5k commented 2 years ago

The label indicator can look cluttered in certain views and for those not familiar with rgb conventions it may be confusing. I prefer the look of the axes without the indicator, so this PR attempts to make it a little cleaner. I did it through kwargs instead of explicit parameter to be minimally invasive.

AlexanderFabisch commented 2 years ago

Hi @alek5k, thanks for the contribution!

Some suggestions:

Since there is already one attribute that is called draw_label, I think it makes more sense to call this argument draw_label_indicator, which should be True by default.
This behavior should be documented in the docstring.
A unit test for this would be nice: https://github.com/alek5k/pytransform3d/blob/develop/pytransform3d/test/test_plot_utils.py#L60 (number of lines should be 3, not 4).

alek5k commented 2 years ago

No problem, thanks for the great library!

I've incorporated your suggestions.

AlexanderFabisch commented 2 years ago

No problem, thanks for the great library!

That's nice to hear, thanks!

I've incorporated your suggestions

I will take a look at it tomorrow in my time zone 🙂

AlexanderFabisch commented 2 years ago

Merged to develop. Thanks again!