dfki-ric / pytransform3d

3D transformations for Python.
https://dfki-ric.github.io/pytransform3d/
Other
615 stars 63 forks source link

[WIP] Refactor TransformManager and introduce TemporalTransformManager #256

Closed AlexanderFabisch closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (101a224) 100.00% compared to head (1f0dcd2) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #256 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 25 28 +3 Lines 2357 2441 +84 Branches 265 280 +15 ========================================= + Hits 2357 2441 +84 ``` | [Impacted Files](https://app.codecov.io/gh/dfki-ric/pytransform3d/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dfki-ric) | Coverage Δ | | |---|---|---| | [pytransform3d/transform\_manager/\_\_init\_\_.py](https://app.codecov.io/gh/dfki-ric/pytransform3d/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dfki-ric#diff-cHl0cmFuc2Zvcm0zZC90cmFuc2Zvcm1fbWFuYWdlci9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [...d/transform\_manager/\_temporal\_transform\_manager.py](https://app.codecov.io/gh/dfki-ric/pytransform3d/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dfki-ric#diff-cHl0cmFuc2Zvcm0zZC90cmFuc2Zvcm1fbWFuYWdlci9fdGVtcG9yYWxfdHJhbnNmb3JtX21hbmFnZXIucHk=) | `100.00% <100.00%> (ø)` | | | [...sform3d/transform\_manager/\_transform\_graph\_base.py](https://app.codecov.io/gh/dfki-ric/pytransform3d/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dfki-ric#diff-cHl0cmFuc2Zvcm0zZC90cmFuc2Zvcm1fbWFuYWdlci9fdHJhbnNmb3JtX2dyYXBoX2Jhc2UucHk=) | `100.00% <100.00%> (ø)` | | | [...ransform3d/transform\_manager/\_transform\_manager.py](https://app.codecov.io/gh/dfki-ric/pytransform3d/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dfki-ric#diff-cHl0cmFuc2Zvcm0zZC90cmFuc2Zvcm1fbWFuYWdlci9fdHJhbnNmb3JtX21hbmFnZXIucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kopytjuk commented 1 year ago

Hey @AlexanderFabisch ,

As you can see in https://github.com/dfki-ric/pytransform3d/pull/257, the state of this PR is fine for the new stateful TemporalManager (great idea btw!).

Two small (non-blocking) remarks:

See you around :)

AlexanderFabisch commented 1 year ago

@kopytjuk

So here are some open points:

For the last point: I think we could do it. We could also do this based on pandas, but only with pandas as an optional dependency. If it is not available, this feature is just not available.

For the documentation I'm not sure how it should be changed. @kopytjuk you are the expert in this domain, would you take a look?

kopytjuk commented 1 year ago

Should we split those two open points in separate PRs?

Currently the changes from this PR affect the "backend" of the lib - after we merge this one into develop we will extend the documentation.

Imho it is easier to digest smaller changes than a huge PR...

AlexanderFabisch commented 1 year ago

Yes, I just did that.