dfki-ric / pytransform3d

3D transformations for Python.
https://dfki-ric.github.io/pytransform3d/
Other
615 stars 63 forks source link

Fix/issue 275 transform ij index is a set #276

Closed BartSte closed 10 months ago

BartSte commented 10 months ago

Closing #275

See the test results here:

Note that 1 test fails. This test also fails in the develop branch and is therefore unrelated to issue #275.

Thanks for sharing this repo!

AlexanderFabisch commented 10 months ago

Hi, thanks for preparing this PR. The test fails because you installed pydot, but you did not install graphviz. pydot calls dot from the graphviz package. The test will only be skipped when pydot is not available. I'm not sure how I should check for dot.

BartSte commented 10 months ago

Thanks for the tip. Now all tests pass:

============================================================================================================= test session starts ==============================================================================================================
platform linux -- Python 3.10.13, pytest-7.4.3, pluggy-1.3.0
rootdir: /home/barts/code/pytransform3d
configfile: setup.cfg
plugins: dash-2.14.1, cov-4.1.0
collected 348 items

pytransform3d/test/test_batch_rotations.py ........................................                                                                                                                                                      [ 11%]
pytransform3d/test/test_camera.py ........                                                                                                                                                                                               [ 13%]
pytransform3d/test/test_coordinates.py ..........                                                                                                                                                                                        [ 16%]
pytransform3d/test/test_geometry.py ..                                                                                                                                                                                                   [ 17%]
pytransform3d/test/test_mesh_loader.py ....                                                                                                                                                                                              [ 18%]
pytransform3d/test/test_plot_utils.py ..........................                                                                                                                                                                         [ 25%]
pytransform3d/test/test_rotations.py ...................................................................................................                                                                                                 [ 54%]
pytransform3d/test/test_trajectories.py .....................                                                                                                                                                                            [ 60%]
pytransform3d/test/test_transform_manager.py ......................                                                                                                                                                                      [ 66%]
pytransform3d/test/test_transformations.py ...................................................                                                                                                                                           [ 81%]
pytransform3d/test/test_uncertainty.py .......                                                                                                                                                                                           [ 83%]
pytransform3d/test/test_urdf.py ..........................................................                                                                                                                                               [100%]

---------- coverage: platform linux, python 3.10.13-final-0 ----------
Coverage HTML written to dir htmlcov

============================================================================================================= 348 passed in 9.08s ==============================================================================================================
AlexanderFabisch commented 9 months ago

I just released 3.5.0.