dflemstr / rq

Record Query - A tool for doing record analysis and transformation
Apache License 2.0
2.28k stars 57 forks source link

MacOS cargo install record-query fails to install #203

Closed EverlastingBugstopper closed 5 years ago

EverlastingBugstopper commented 5 years ago

OS: MacOS Mojave 10.14.6

$ rustc -V
rustc 1.37.0 (eae3437df 2019-08-13)
$ cargo install record-query
    Updating crates.io index
  Downloaded record-query v0.10.4
  Downloaded 1 crate (334.5 KB) in 1.01s
  Installing record-query v0.10.4
error: failed to compile `record-query v0.10.4`, intermediate artifacts can be found at `/var/folders/xw/4ttxd3d12t79cv0cb78gwhzc0000gn/T/cargo-install0ONYCy`

Caused by:
  failed to select a version for `toml`.
    ... required by package `record-query v0.10.4`
versions that meet the requirements `^0.3.0` are: 0.3.2, 0.3.1, 0.3.0

the package `record-query` depends on `toml`, with features: `serde` but `toml` does not have these features.
 It has a required dependency with that name, but only optional dependencies can be used as features.

I realize this is in low maintenance mode but figured I would file the issue regardless! 😄

EverlastingBugstopper commented 5 years ago

Tried building from source and got a different error

$ cargo install --git https://github.com/dflemstr/rq --branch master
...
error: failed to compile `record-query v0.10.4 (https://github.com/dflemstr/rq#8619ccf1)`, intermediate artifacts can be found at `/var/folders/xw/4ttxd3d12t79cv0cb78gwhzc0000gn/T/cargo-installeX6Mzw`

Caused by:
  failed to run custom build command for `v8-sys v0.15.0`

Caused by:
  process didn't exit successfully: `/var/folders/xw/4ttxd3d12t79cv0cb78gwhzc0000gn/T/cargo-installeX6Mzw/release/build/v8-sys-71d3e4b375a65ca8/build-script-build` (exit code: 1)
--- stdout
cargo:rerun-if-changed=src/v8-trampoline.h
cargo:rerun-if-changed=src/v8-glue.h
cargo:rerun-if-changed=src/v8-glue.cc
-I"/usr/local/include"
-I"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.1/include"
-I"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include"
-I"/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include"
-I"/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks"
preferring static linking: true
cargo:warning=pkg-config failed, falling back to naïve lib search: Err(Failure { command: "\"pkg-config\" \"--static\" \"--libs\" \"--cflags\" \"v8\"", output: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "Package v8 was not found in the pkg-config search path.\nPerhaps you should add the directory containing `v8.pc\'\nto the PKG_CONFIG_PATH environment variable\nNo package \'v8\' found\n" } })
cargo:rustc-link-search=native=/usr/lib
cargo:rustc-link-search=native=/usr/local/lib
cargo:rustc-link-search=native=/usr/local/opt/icu4c/lib
cargo:rustc-link-lib=static=v8_base
cargo:rustc-link-lib=static=v8_libbase
cargo:rustc-link-lib=static=v8_libsampler
cargo:rustc-link-lib=static=v8_nosnapshot
cargo:rustc-link-lib=static=icui18n
cargo:rustc-link-lib=static=icuuc
cargo:rustc-link-lib=static=icudata
TARGET = Some("x86_64-apple-darwin")
OPT_LEVEL = Some("3")
HOST = Some("x86_64-apple-darwin")
CXX_x86_64-apple-darwin = None
CXX_x86_64_apple_darwin = None
HOST_CXX = None
CXX = None
CXXFLAGS_x86_64-apple-darwin = None
CXXFLAGS_x86_64_apple_darwin = None
HOST_CXXFLAGS = None
CXXFLAGS = None
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("false")
CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2,sse3,ssse3")
running: "c++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "src" "-I" "/var/folders/xw/4ttxd3d12t79cv0cb78gwhzc0000gn/T/cargo-installeX6Mzw/release/build/v8-sys-792e4e7104e2248d/out" "-Wall" "-Wextra" "-std=c++11" "-Wall" "-o" "/var/folders/xw/4ttxd3d12t79cv0cb78gwhzc0000gn/T/cargo-installeX6Mzw/release/build/v8-sys-792e4e7104e2248d/out/src/v8-glue.o" "-c" "src/v8-glue.cc"
cargo:warning=In file included from src/v8-glue.cc:1:
cargo:warning=src/v8-glue.h:3:10: fatal error: 'v8.h' file not found
cargo:warning=#include <v8.h>
cargo:warning=         ^~~~~~
cargo:warning=1 error generated.
exit code: 1

--- stderr
src/v8-trampoline.h:3:10: fatal error: 'v8.h' file not found

error occurred: Command "c++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "src" "-I" "/var/folders/xw/4ttxd3d12t79cv0cb78gwhzc0000gn/T/cargo-installeX6Mzw/release/build/v8-sys-792e4e7104e2248d/out" "-Wall" "-Wextra" "-std=c++11" "-Wall" "-o" "/var/folders/xw/4ttxd3d12t79cv0cb78gwhzc0000gn/T/cargo-installeX6Mzw/release/build/v8-sys-792e4e7104e2248d/out/src/v8-glue.o" "-c" "src/v8-glue.cc" with args "c++" did not execute successfully (status code exit code: 1).
dflemstr commented 5 years ago

The latest version no longer depends on v8 and should build successfully on mac!

EverlastingBugstopper commented 5 years ago

Awesome!! Thanks for the update 😁