Fix building on Rust 1.51.0

dflemstr / rq

Record Query - A tool for doing record analysis and transformation

Apache License 2.0

2.28k stars 57 forks source link

Fix building on Rust 1.51.0 #216

Closed DeeUnderscore closed 3 years ago

DeeUnderscore commented 3 years ago

rq currently fails to build on Rust 1.51.0 due to tripping the non-fmt-panic lint (and having #![deny(warnings)] set). This patch allows it to build on 1.51.0.

dflemstr commented 3 years ago

Good catch, thanks for the PR!

jcaesar commented 3 years ago

This problem caused rq to be dropped from Gentoo. https://bugs.gentoo.org/786279 Might be a good idea to do a support release.

(I wonder if it would be a good idea to hide those #[deny(warnings)] behind a feature flag that is only on during CI. -Werror has seen some criticism precisely because of this kind of problem. If you want a PR, do tell.)