Refcount Isolate instead of borrowing it

dflemstr / v8-rs

An idiomatic Rust wrapper for the V8 Javascript engine

107 stars 16 forks source link

Refcount Isolate instead of borrowing it #4

Closed dflemstr closed 7 years ago

dflemstr commented 7 years ago

This should hopefully simplify the API a lot by not forcing the user to use lifetimes. It also enables us to avoid one level of indirection when adding callbacks, bringing us closer to unboxed-ish closures.

codecov-io commented 7 years ago

Current coverage is 89.14% (diff: 100%)

Merging #4 into master will decrease coverage by 0.80%

@@             master         #4   diff @@
==========================================
  Files            11         11          
  Lines           995       1032    +37   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            895        920    +25   
- Misses          100        112    +12   
  Partials          0          0

Powered by Codecov. Last update 895e99a...6be67c7

tcosprojects commented 7 years ago

Great change. This resolves an issue I was running into where I couldn't hold a context and an isolate in a struct together. Thanks!