search

dflook / cloudformation-dns-certificate

Cloudformation DNS Validated Certificate Resource
MIT License
48 stars 13 forks source link

Warnings from cfn-lint about AWS partitions #19

Closed CurryEleison closed 1 year ago

CurryEleison commented 1 year ago

cfn-lint issues a warning I3042 on the provided templates. I made a PR with a fix and provide more detail in the PR description: #18 . Feel free to close this without merging if you think it isn't necessary.

dflook commented 1 year ago

Hi @CurryEleison, how did you get rule I3042 to trigger? My version of cfn-lint (0.72.10) doesn't seem to.

CurryEleison commented 1 year ago

cfn-lint will exclude all checks beginning with I by default. So to repro you need to include all the cfn-lint checks with

cfn-lint -c I -- cloudformation.yaml

(this is clarified at https://github.com/aws-cloudformation/cfn-lint#info-rules )

Sorry for not realizing this. I was using a VS Code cfn-lint plugin that defaulted to run the informational checks and assumed it was the default also on the command line.

dflook commented 1 year ago

Resolved in #18