search

dflourusso / expo-sqlite-orm

Expo SQLite ORM
132 stars 34 forks source link

Make primary key autoincrement optional #21

Closed sebastianwd closed 2 years ago

sebastianwd commented 4 years ago

Currently the field declared as primary key in models is set to autoincrement by default, this means that if we want a TEXT primary key the code will just throw an error because a TEXT field can't be autoincremented.

I added an optional parameter autoincrement to fields declaration

orhangazi commented 2 years ago

This must be accepted. We need it.

dflourusso commented 2 years ago

Hello, awesome pull request. I would like to request some changes before the merge, please.

  1. Modify the README with usage examples of your implementation
  2. Add unit tests covering your change
dflourusso commented 2 years ago

Hello, I requested some changes, and they were not done. So I implemented this feature, and I'm closing this pull request.