search

dflydev / dflydev-doctrine-orm-service-provider

Doctrine ORM Service Provider
MIT License
209 stars 59 forks source link

Early migration to be ready for Pimple service provider #3

Closed simensen closed 12 years ago

simensen commented 12 years ago

Leave door open for integration into other Pimple based projects.

Taluu commented 12 years ago

Hello,

Seems good, but I am wondering, why instead of proxying your DoctrineORMProvider in your Silex's and Cilex's providers, you do not just extend the main Pimple Class ? I can be wrong here though...

simensen commented 12 years ago

@Taluu The reason is that the Silex Service Provider Interface expects a Silex\Application and the Cilex Service Provider Interface expects a Cilex\Application. They both extend \Pimple but they both currently impose a specific implementation of \Pimple currently.

Eventually Pimple will have first class support for Pimple Service Providers and at that point we can probably get rid of the application-specific providers entirely. This is sort of a bridge to get from here to there and exposing the Doctrine ORM capabilities to any Pimple application.

I was looking for you earlier today because I wanted to get your feedback on it. I'd also like to see if you could test this out and make sure I haven't broken anything. :) The tests still work/pass so I think it is OK but would love a second set of eyes. :)

Taluu commented 12 years ago

OK, that's what I Thought, I wasn't sure that either Silex or Cilex interfaces wanted specifically their own interfaces, even if they look alike.

But ok, i'll try it sometimes, but as i said, it seems all good to me. :)