search

dflydev / dflydev-doctrine-orm-service-provider

Doctrine ORM Service Provider
MIT License
209 stars 59 forks source link

Support custom cache drivers in orm.cache.factory #59

Closed c960657 closed 9 years ago

c960657 commented 9 years ago

The cache driver factory, orm.cache.factory, only supports the predefined cache drivers.

With this PR, the factory also supports custom cache drivers.

simensen commented 9 years ago

I think this should be fine. Not sure if changing the structure of an Exception message would constitute a BC break? What do you think?

c960657 commented 9 years ago

People matching the human-readable exception message should not be surprised by wording changes.

On the other hand, the new message is not a big improvement over the old one (it might even be less helpful in the common usecase where someone just made a spelling mistake when specifying the driver), so I will revert the change.

simensen commented 9 years ago

@c960657 I actually like it; just not sure how safe it is. :) You could add in parens "(is it spelled correctly?)" or something?

c960657 commented 9 years ago

Done :-)

I think this is a minor BC break that only affects some very unusual use-cases, so I think it is acceptable.

simensen commented 9 years ago

@c960657 thanks! appreciate it. :)

hkdobrev commented 6 years ago

@simensen Could you release a new stable version including this enhancement? Thank you!

hkdobrev commented 5 years ago

@simensen 👋 Do you think a new version could be released with this? E.g. 2.1.0.