search

dflydev / dflydev-doctrine-orm-service-provider

Doctrine ORM Service Provider
MIT License
209 stars 59 forks source link

Add mapping driver factory #60

Open c960657 opened 9 years ago

c960657 commented 9 years ago

This PR adds a mapping driver factory, orm.mapping.factory, following the same pattern as orm.cache.factory.

It supports custom mapping drivers like it has been proposed for cache drivers in #59.

The factory methods requires a Configuration instance to be passed. This is only used by the "annotation" driver and could be avoided by inlining the code in Doctrine\ORM\Configuration::newDefaultAnnotationDriver(). This would make the API cleaner but create make a stronger coupling to Doctrine ORM, so I kept the existing implementation. Agree?

simensen commented 9 years ago

@dominikzogg Would you mind taking a look at this (and #59 in retrospect) if you get a chance? This looks heavier than I'd like to merge on a whim and I don't have the time to look at this for at least a week or so.

@c960657 thanks for your help on this! I definitely like the direction. :) If I can get another set of eyes on it we can probably get it merged.