search

dflydev / dflydev-fig-cookies

Cookies for PSR-7 HTTP Message Interface.
MIT License
224 stars 29 forks source link

PHP8 Support #38

Closed canvural closed 3 years ago

canvural commented 3 years ago

Hello,

One of the libraries I depend on has a dependency on this package. So while trying to upgrade to PHP8 I saw this package is not compatible.

Is there any plan to add support for PHP 8? If not, I can do it. Would you be interested merging that?

As far as I see it's relatively easy upgrade. Only problem I see is tests using prophesize which is deprecated in PHPUnit 9. https://github.com/phpspec/prophecy-phpunit is recommended but that requires min. PHP 7.3 So I don't know any what to do in that case, but open to discussion.

simensen commented 3 years ago

@canvural Indeed, I dropped the ball on this one. :( Someone opened #39 to try to properly support PHP 8 and I'm going to see if I can get some help following up on it and getting it merged ASAP if it's all good.

canvural commented 3 years ago

Yeah that's also my PR :smile:

simensen commented 3 years ago

@canvural D'oh. My bad for not noticing. Thank you so much for working on this for me! If we get the PR merged we'll get this issue closed. :)

simensen commented 3 years ago

This should be fixed, now. Thanks for your help!