Allow import of vendor scripts from another domain

dflynn15 / gulp-jasmine-phantom

Gulp plugin to run Jasmine tests with Phantom or mininodejasmine2.

27 stars 30 forks source link

Allow import of vendor scripts from another domain #35

Closed adammark closed 9 years ago

adammark commented 9 years ago

Hi, this small change allows you to include vendor scripts which may reside at another domain (for example, a CDN). API is the same—vendor option still accepts a string or array, e.g.

vendor: [
  './my/scripts/jquery.js',
  'http://somecdn.com/some/script.js'
]

Note I did not update the README file.

Thanks, Adam

dflynn15 commented 9 years ago

I think this is a good solution. I hadn't thought of using CDNs for testing. Could you please update the README to reflect this change?

adammark commented 9 years ago

Done, thanks.

adammark commented 9 years ago

Hi, any movement on this? Doc is updated. Thanks.

dflynn15 commented 9 years ago

I have been away. Everything has been updated and npm version has been bumped.

adammark commented 9 years ago

Super, thanks.