search

dflynn15 / gulp-jasmine-phantom

Gulp plugin to run Jasmine tests with Phantom or mininodejasmine2.
27 stars 30 forks source link

Install phantomJs as a dependency and run test with this phantomJs #37

Closed hgarcia closed 9 years ago

hgarcia commented 9 years ago

Avoids the need of a global phantomJs. Simplifies the deployment and build process in your CI. We are building an array of services and applications and we need them to be self contained, this allow us to just do clone, npm install npm test and npm start without the need or anything installed globally. The code was taken from the karma-phantomjs-launcher that uses a local phantomJs as well. Cheers.

dflynn15 commented 9 years ago

I have already addressed a similar issue on #21, but I do no plan to add PhantomJS to the package.json. For specific reasons please go visit the closed issue.

However, I am in progress of adding the ability to set the path to Phantom you wish to use. In that case you can include PhantomJS in your own package.json and point to that package's path to run it.

In this way we can avoid pulling down multiple versions of PhantomJS based on other modules you may be including and speed up the overall npm install.

You can track the status of this through issue #33 or submit a PR that allows for the configuration of the executable path.

hgarcia commented 9 years ago

Thanks