dfm / araa-gps

Souce code for our ARA&A review of Gaussian process regression for astronomical time-series
MIT License
28 stars 6 forks source link

Scientific editor 1 comments #37

Closed saigrain closed 1 year ago

saigrain commented 1 year ago
saigrain commented 1 year ago

@dfm, I've ticked all the comments that are already dealt with. On the last 2:

dfm commented 1 year ago

Thanks @saigrain!

I could remove the repeated text in Section 3.2, or do you think we should leave it?

I'm happy for us to cut it!

I would be tempted to push back on this because I've yet to come across a dataset where I could safely say there's no correlated noise before analysing it... What's your view?

I'm totally with you! We could comment that there may be cases where a model of the correlated noise is not required to adequately model the data but, since the independent noise model is a special case of most GP models, using a GP isn't conceptually problematic - especially when you use the model assessment tools discussed here. There may be computational reasons or non-Gaussianity that could cause you to avoid using a GP, but we also discuss that.