search

dfm / araa-gps

Souce code for our ARA&A review of Gaussian process regression for astronomical time-series
MIT License
28 stars 6 forks source link

add static RV framework figure #4

Closed saigrain closed 2 years ago

saigrain commented 2 years ago

Hi Dan, am I doing this right...?

dfm commented 2 years ago

I think so! Let's try merging and see if it ends up in the Overleaf...

dfm commented 2 years ago

hmm doesn't seem to be working. I'll debug a little!

github-actions[bot] commented 2 years ago

Here is the compiled article PDF, as well as the PDF with highlighted changes, for the latest commit. You can find additional build output at pull-request-4-pdf.

dfm commented 2 years ago

OK working now! I've added a placeholder for that figure in the RV stellar variability section.

saigrain commented 2 years ago

Ok, out of interest what did you have to change?

From: Dan Foreman-Mackey @.> Sent: 07 September 2022 18:04 To: dfm/araa-gps @.> Cc: Suzanne Aigrain @.>; Author @.> Subject: Re: [dfm/araa-gps] add static RV framework figure (PR #4)

OK working now! I've added a placeholder for that figure in the RV stellar variability section.

— Reply to this email directly, view it on GitHubhttps://github.com/dfm/araa-gps/pull/4#issuecomment-1239655953, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAKAOODQH5YJAXDG5YD2XLV5DDJJANCNFSM6AAAAAAQG6GXOM. You are receiving this because you authored the thread.Message ID: @.**@.>>

dfm commented 2 years ago

We needed to have the figure environment in the Overleaf document for showyourwork to recognize that it needed to push that file, but the issue I was having was caused by the Overleaf being slow to sync, I think!

saigrain commented 2 years ago

Cool! I’m signing off for today. Tomorrow I’ll make another (probably also static) figure for the basic GPR workflow

From: Dan Foreman-Mackey @.> Sent: 07 September 2022 18:07 To: dfm/araa-gps @.> Cc: Suzanne Aigrain @.>; Author @.> Subject: Re: [dfm/araa-gps] add static RV framework figure (PR #4)

We needed to have the figure environment in the Overleaf document for showyourwork to recognize that it needed to push that file, but the issue I was having was caused by the Overleaf being slow to sync, I think!

— Reply to this email directly, view it on GitHubhttps://github.com/dfm/araa-gps/pull/4#issuecomment-1239658734, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAKAOMYSTD3TR4BAMT6NNTV5DDU3ANCNFSM6AAAAAAQG6GXOM. You are receiving this because you authored the thread.Message ID: @.**@.>>