search

dfm / feedfinder2

A Python library for finding feed links on websites.
MIT License
49 stars 21 forks source link

Allow find_feeds() to take an allow_redirects argument to pass to requests #10

Open brendan-dorsey opened 6 years ago

brendan-dorsey commented 6 years ago

Currently, there is no way to handle redirects explicitly. I ran into some issues with this when iterating over a large number of URLs with widely varying formats. If my script hit a URL with too many redirects, requests would fail but without raising an explicit error, hanging the entire script.

dfm commented 6 years ago

This is a great suggestion! I don't really have the time to implement this right at the moment, but I would welcome a pull request :-)

brendan-dorsey commented 6 years ago

Awesome. Will do today!

On Fri, Nov 17, 2017 at 8:54 AM Dan Foreman-Mackey notifications@github.com wrote:

This is a great suggestion! I don't really have the time to implement this right at the moment, but I would welcome a pull request :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dfm/feedfinder2/issues/10#issuecomment-345299806, or mute the thread https://github.com/notifications/unsubscribe-auth/AYZ6HfiYYFMUhvs-QRBSQuyT--wkQviAks5s3bpFgaJpZM4QfcUJ .