search

dfm / osrc

The Open Source Report Card
http://osrc.dfm.io
MIT License
1.03k stars 135 forks source link

Not handling the international Dateline well #113

Open Aethylred opened 10 years ago

Aethylred commented 10 years ago

Looking at my schedule: http://osrc.dfm.io/aethylred#schedule

You can see commits on a Sunday, and few on a Friday. This is not correct.

It looks like the weekdays are not correctly shifted to match my timezone (NZT/NZDT or UTC+12/UTC+13) while my working hours are correct.

Senjai commented 10 years ago

Does github make your time zone public?

Aethylred commented 10 years ago

Kind of, it can be figured from your location.

Senjai commented 10 years ago

If its not provided by the API, its not fair or really important to ask this application to do this.

Aethylred commented 10 years ago

Fairness has nothing to do with it. It's an issue, I've reported it, it's up to the maintainers do decide if it needs to be fixed or not fixed, either way an unexpected outcome is described, discussed and resolved. This is how software development works.

Senjai commented 10 years ago

Feel free to submit a pr.

dfm commented 10 years ago

Sorry for being MIA. This is actually something that I've wanted to fix for a while (see my tongue-in-cheek issue #19) so thanks for reminding me! I don't seem to have much time to work on OSRC these days but hopefully I can get to it soon! I do resolve the timezone so it's only a matter of shifting the weekly schedule.