search

dfm / osrc

The Open Source Report Card
http://osrc.dfm.io
MIT License
1.03k stars 137 forks source link

Incorrectly guessing my timezone #86

Open amandasaurus opened 10 years ago

amandasaurus commented 10 years ago

There's probably a bug in handlying timezones. My page ( http://osrc.dfm.io/rory ) says I do most of my work at 4am and work during the night. I don't do that! my location in github is set as "Dublin, Ireland, EU"

ereOn commented 10 years ago

Same issue here. I'm not sure there is any guessing of the timezone, but there could be as the time information seems a bit off.

Aside from that, awesome project, I love it !

KonradIT commented 10 years ago

Same here, http://osrc.dfm.io/konradit says that I commit at 6 pm! I do other stuff at 6 pm

dfm commented 10 years ago

The original issue should now be fixed (as of quite a while ago).

@ereOn: your issue is that you don't have a location on your profile so there's nothing that we can use to guess a timezone!

@KonradIT: your timezone is guessed to be +1 (see the JSON) because you're labelled as in Madrid. Is that incorrect?

KonradIT commented 10 years ago

@dfm , yes i live in Madrid, but I don't code at 6 pm.

ereOn commented 10 years ago

@dfm: If you had made some research on the internet, you could have found my birthplace and deduced my current location... Just kidding ;)

I wasn't aware there was a location setting and thought the location was deduced by Github using GeoIP or something like it. I set it up and it's now showing the real time.

Sorry for the false bug report. Awesome works you did there.

Thanks !

dfm commented 10 years ago

@ereOn: ha! Glad it works now.

@KonradIT: then it doesn't sound like a time zone issue. Feel free to open another issue if there's no chance that you ever interacted with GitHub in the evening but you'll need to give more info than "I never work at 6". Did you ever, for example, spend time in a different time zone?

KonradIT commented 10 years ago

@dfm I am at school from 8pm to 16:40pm, on mondays there are ICT lessons, so I code on Mondays from 15:50 to 16:40. In the week, I code normally after homework, from aprox. 5pm to 7pm. On weekends I code the most of all the days. From 12pm to 1pm and in the morning, but I almost don't code in the evening. I live in Madrid, and I didn't go to any were since December, there I coded very little. There must be something wrong with the geo IP time zone detector Osrc is using.

amandasaurus commented 10 years ago

Yes this seems to be fixed for me. Thanks