dfmotty / google-gson

Automatically exported from code.google.com/p/google-gson
0 stars 0 forks source link

LazilyParsedNumber does not implement eqals and hashCode methods #627

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
test case to reproduce the issue

package com.google.gson.internal;

import junit.framework.TestCase;

public class LazilyParsedNumberTest extends TestCase {

    public void testHashCode(){
        LazilyParsedNumber n1 = new LazilyParsedNumber("1");
        LazilyParsedNumber n1Another = new LazilyParsedNumber("1");
        assertEquals(n1.hashCode(), n1Another.hashCode());
    }

    public void testEquals(){
        LazilyParsedNumber n1 = new LazilyParsedNumber("1");
        LazilyParsedNumber n1Another = new LazilyParsedNumber("1");
        assertTrue(n1.equals(n1Another));
    }

What is the expected output? What do you see instead?
Any class should implement hashCode and equals when implementing Number 
interface.

What version of the product are you using? On what operating system?
2.3

Please provide any additional information below.
https://code.google.com/p/google-gson/issues/detail?id=523
Similar one.

I could work on these, but first I would like to know if there was any reason 
you decided not to implement these methods? 

Original issue reported on code.google.com by vrab...@gmail.com on 4 Feb 2015 at 12:06

GoogleCodeExporter commented 9 years ago
This was an oversight. We should fix this. Thanks for the bug report and a 
nicely written test.

Original comment by inder123 on 12 Feb 2015 at 5:31

GoogleCodeExporter commented 9 years ago
Thanks.
Do you have any plans with the 523?

I am not sure what the comment in the 523 bug report means.

Do you try implement equals to behave like in javascript?
1.0 == 1 

In this case implementing equals and hashCode to fulfill the java contract 
would need more work than just ask IDE to generate equals and hashCode methods.

Original comment by vrab...@gmail.com on 13 Feb 2015 at 8:18