Closed survived closed 7 months ago
The changes seem logical and consistent to me. Since the changes concern encoding of fields, hashing, etc., I think tests are ideal to give us confidence on their correctness. @survived I guess all the changes are covered in tests, right?
@OrestisAlpos We have tests in udigest library that test that encoding is correct. In cggmp21, we have only e2e tests that ensure that keygen/signing still works correctly
Note: CI is currently failing because of patched deps which will be resolved when https://github.com/dfns-labs/generic-ec/pull/10 and https://github.com/dfns-labs/udigest/pull/1 are merged.