search

dfns / cggmp21

State-of-art threshold ECDSA in Rust
Apache License 2.0
41 stars 6 forks source link

Add yield points, improve profiling #66

Closed survived closed 7 months ago

maurges commented 7 months ago

How sneaky, I had some comments on the draft, but you moved all the interesting stuff into round-based

maurges commented 7 months ago

I think we should also insert yields into key refresh, it's full of heavy operations

survived commented 7 months ago

How sneaky, I had some comments on the draft, but you moved all the interesting stuff into round-based

Like what? I don't remember anything interesting there. The only thing I moved to round-based is tokio::task::yield_now, instead I added abstraction AsyncRuntime that exposes yield_now which may be different per runtime

survived commented 7 months ago

I think we should also insert yields into key refresh, it's full of heavy operations

Yeah but given that we do it only once, I didn't want to do that in this PR. We can add it to issues as a todo