search

dfns / cggmp21

State-of-art threshold ECDSA in Rust
Apache License 2.0
41 stars 6 forks source link

Fix missing fields in key-share manifest #77

Closed maurges closed 4 months ago

github-actions[bot] commented 4 months ago

Crate direct deps

Direct deps ```text cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen) digest v0.10.6 futures v0.3.24 generic-ec v0.1.3 generic-ec-zkp v0.1.1 hex v0.4.3 paillier-zk v0.1.0 rand_chacha v0.3.1 rand_core v0.6.4 round-based v0.2.0 serde v1.0.188 serde_with v2.3.3 sha2 v0.10.6 thiserror v1.0.48 udigest v0.1.0 ```

Compared to base branch

Diff ```text --- direct-deps-base 2024-02-19 14:34:58.253603180 +0000 +++ direct-deps-pr 2024-02-19 14:34:58.525600931 +0000 @@ -1 +1 @@ -cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen) +cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen) ```

All deps

cargo tree ```text cggmp21 v0.2.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21) ├── cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen) │ ├── digest v0.10.6 │ │ ├── block-buffer v0.10.3 │ │ │ └── generic-array v0.14.6 │ │ │ ├── serde v1.0.188 │ │ │ │ └── serde_derive v1.0.188 (proc-macro) │ │ │ │ ├── proc-macro2 v1.0.66 │ │ │ │ │ └── unicode-ident v1.0.4 │ │ │ │ ├── quote v1.0.33 │ │ │ │ │ └── proc-macro2 v1.0.66 (*) │ │ │ │ └── syn v2.0.32 │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── unicode-ident v1.0.4 │ │ │ └── typenum v1.15.0 │ │ └── crypto-common v0.1.6 │ │ ├── generic-array v0.14.6 (*) │ │ └── typenum v1.15.0 │ ├── futures v0.3.24 │ │ ├── futures-channel v0.3.24 │ │ │ ├── futures-core v0.3.24 │ │ │ └── futures-sink v0.3.24 │ │ ├── futures-core v0.3.24 │ │ ├── futures-executor v0.3.24 │ │ │ ├── futures-core v0.3.24 │ │ │ ├── futures-task v0.3.24 │ │ │ └── futures-util v0.3.24 │ │ │ ├── futures-channel v0.3.24 (*) │ │ │ ├── futures-core v0.3.24 │ │ │ ├── futures-io v0.3.24 │ │ │ ├── futures-macro v0.3.24 (proc-macro) │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── syn v1.0.101 │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── unicode-ident v1.0.4 │ │ │ ├── futures-sink v0.3.24 │ │ │ ├── futures-task v0.3.24 │ │ │ ├── memchr v2.5.0 │ │ │ ├── pin-project-lite v0.2.9 │ │ │ ├── pin-utils v0.1.0 │ │ │ └── slab v0.4.7 │ │ ├── futures-io v0.3.24 │ │ ├── futures-sink v0.3.24 │ │ ├── futures-task v0.3.24 │ │ └── futures-util v0.3.24 (*) │ ├── generic-ec v0.1.3 │ │ ├── generic-ec-core v0.1.2 │ │ │ ├── generic-array v0.14.6 (*) │ │ │ ├── rand_core v0.6.4 │ │ │ ├── serde v1.0.188 (*) │ │ │ ├── subtle v2.4.1 │ │ │ └── zeroize v1.6.0 │ │ │ └── zeroize_derive v1.3.2 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ ├── syn v1.0.101 (*) │ │ │ └── synstructure v0.12.6 │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ ├── syn v1.0.101 (*) │ │ │ └── unicode-xid v0.2.4 │ │ ├── getrandom v0.2.10 │ │ │ ├── cfg-if v1.0.0 │ │ │ └── libc v0.2.148 │ │ ├── hex v0.4.3 │ │ │ └── serde v1.0.188 (*) │ │ ├── phantom-type v0.4.2 │ │ │ └── educe v0.4.19 (proc-macro) │ │ │ ├── enum-ordinalize v3.1.11 (proc-macro) │ │ │ │ ├── num-bigint v0.4.3 │ │ │ │ │ ├── num-integer v0.1.45 │ │ │ │ │ │ └── num-traits v0.2.15 │ │ │ │ │ └── num-traits v0.2.15 │ │ │ │ ├── num-traits v0.2.15 │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── syn v1.0.101 (*) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v1.0.101 (*) │ │ ├── rand_core v0.6.4 │ │ ├── serde v1.0.188 (*) │ │ ├── serde_with v2.3.3 │ │ │ ├── serde v1.0.188 (*) │ │ │ └── serde_with_macros v2.3.3 (proc-macro) │ │ │ ├── darling v0.20.1 │ │ │ │ ├── darling_core v0.20.1 │ │ │ │ │ ├── fnv v1.0.7 │ │ │ │ │ ├── ident_case v1.0.1 │ │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ │ ├── strsim v0.10.0 │ │ │ │ │ └── syn v2.0.32 (*) │ │ │ │ └── darling_macro v0.20.1 (proc-macro) │ │ │ │ ├── darling_core v0.20.1 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── syn v2.0.32 (*) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v2.0.32 (*) │ │ ├── subtle v2.4.1 │ │ ├── udigest v0.1.0 │ │ │ ├── digest v0.10.6 (*) │ │ │ └── udigest-derive v0.1.0 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v2.0.32 (*) │ │ └── zeroize v1.6.0 (*) │ ├── generic-ec-zkp v0.1.1 │ │ ├── generic-array v0.14.6 (*) │ │ ├── generic-ec v0.1.3 (*) │ │ ├── rand_core v0.6.4 │ │ ├── serde v1.0.188 (*) │ │ ├── subtle v2.4.1 │ │ └── udigest v0.1.0 (*) │ ├── hex v0.4.3 (*) │ ├── key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) │ │ ├── generic-ec v0.1.3 (*) │ │ ├── generic-ec-zkp v0.1.1 (*) │ │ ├── hex v0.4.3 (*) │ │ ├── serde v1.0.188 (*) │ │ ├── serde_with v2.3.3 (*) │ │ └── thiserror v1.0.48 │ │ └── thiserror-impl v1.0.48 (proc-macro) │ │ ├── proc-macro2 v1.0.66 (*) │ │ ├── quote v1.0.33 (*) │ │ └── syn v2.0.32 (*) │ ├── rand_core v0.6.4 │ ├── round-based v0.2.0 │ │ ├── futures-util v0.3.24 (*) │ │ ├── phantom-type v0.3.1 │ │ │ └── educe v0.4.19 (proc-macro) (*) │ │ ├── round-based-derive v0.2.0 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v1.0.101 (*) │ │ ├── thiserror v1.0.48 (*) │ │ └── tracing v0.1.36 │ │ ├── cfg-if v1.0.0 │ │ ├── pin-project-lite v0.2.9 │ │ ├── tracing-attributes v0.1.22 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v1.0.101 (*) │ │ └── tracing-core v0.1.29 │ │ └── once_cell v1.17.0 │ ├── serde v1.0.188 (*) │ ├── serde_with v2.3.3 (*) │ ├── sha2 v0.10.6 │ │ ├── cfg-if v1.0.0 │ │ ├── cpufeatures v0.2.5 │ │ └── digest v0.10.6 (*) │ ├── thiserror v1.0.48 (*) │ └── udigest v0.1.0 (*) ├── digest v0.10.6 (*) ├── futures v0.3.24 (*) ├── generic-ec v0.1.3 (*) ├── generic-ec-zkp v0.1.1 (*) ├── hex v0.4.3 (*) ├── paillier-zk v0.1.0 │ ├── digest v0.10.6 (*) │ ├── fast-paillier v0.1.0 │ │ ├── bytemuck v1.13.1 │ │ │ └── bytemuck_derive v1.4.1 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v2.0.32 (*) │ │ ├── rand_core v0.6.4 │ │ ├── rug v1.21.0 │ │ │ ├── az v1.2.1 │ │ │ ├── gmp-mpfr-sys v1.6.1 │ │ │ │ └── libc v0.2.148 │ │ │ ├── libc v0.2.148 │ │ │ └── serde v1.0.188 (*) │ │ ├── serde v1.0.188 (*) │ │ └── thiserror v1.0.48 (*) │ ├── generic-ec v0.1.3 (*) │ ├── rand_core v0.6.4 │ ├── rug v1.21.0 (*) │ ├── serde v1.0.188 (*) │ ├── serde_with v3.0.0 │ │ ├── serde v1.0.188 (*) │ │ └── serde_with_macros v3.0.0 (proc-macro) │ │ ├── darling v0.20.1 (*) │ │ ├── proc-macro2 v1.0.66 (*) │ │ ├── quote v1.0.33 (*) │ │ └── syn v2.0.32 (*) │ └── thiserror v1.0.48 (*) ├── rand_chacha v0.3.1 │ ├── ppv-lite86 v0.2.17 │ └── rand_core v0.6.4 ├── rand_core v0.6.4 ├── round-based v0.2.0 (*) ├── serde v1.0.188 (*) ├── serde_with v2.3.3 (*) ├── sha2 v0.10.6 (*) ├── thiserror v1.0.48 (*) └── udigest v0.1.0 (*) ```

Compared to base branch

Diff ```text --- all-deps-base 2024-02-19 14:34:58.385602089 +0000 +++ all-deps-pr 2024-02-19 14:34:58.649599905 +0000 @@ -6 +6 @@ -cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen) +cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen) @@ -34 +34 @@ -key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share) +key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) ```
github-actions[bot] commented 4 months ago

Benchmark Result

Benchmarks ```text RUST_TESTS_SEED=b9f9116422255a4614d3a7bb60e29f5f31bf1b4196612d0165299b6ac6a7320f n = 3 Non-threshold DKG Protocol Performance: - Protocol took 510.58µs to complete In particular: - Stage: 13.41µs - Setup networking: 13.05µs (97.3%) - Unstaged: 360.00ns (2.7%) - Round 1: 215.69µs - Compute execution id: 11.28µs (5.2%) - Sample x_i, rid_i, chain_code: 103.00µs (47.8%) - Sample schnorr commitment: 79.60µs (36.9%) - Commit to public data: 21.40µs (9.9%) - Unstaged: 411.00ns (0.2%) - Round 2: 3.12µs - Hash received msgs (reliability check): 2.88µs (92.2%) - Unstaged: 242.00ns (7.8%) - Round 3: 321.00ns - Assert other parties hashed messages (reliability check): 161.00ns (50.2%) - Unstaged: 160.00ns (49.8%) - Round 4: 39.10µs - Validate decommitments: 33.30µs (85.2%) - Calculate challege rid: 5.35µs (13.7%) - Prove knowledge of `x_i`: 280.00ns (0.7%) - Unstaged: 170.00ns (0.4%) - Round 5: 238.93µs - Validate schnorr proofs: 238.57µs (99.8%) - Unstaged: 361.00ns (0.2%) Threshold DKG Protocol Performance: - Protocol took 1.78ms to complete In particular: - Stage: 2.01µs - Setup networking: 1.95µs (97.0%) - Unstaged: 60.00ns (3.0%) - Round 1: 202.46µs - Compute execution id: 801.00ns (0.4%) - Sample rid_i, schnorr commitment, polynomial, chain_code: 179.53µs (88.7%) - Commit to public data: 21.94µs (10.8%) - Unstaged: 190.00ns (0.1%) - Round 2: 1.48µs - Hash received msgs (reliability check): 1.23µs (83.1%) - Unstaged: 250.00ns (16.9%) - Round 3: 411.00ns - Assert other parties hashed messages (reliability check): 220.00ns (53.5%) - Unstaged: 191.00ns (46.5%) - Round 4: 1.31ms - Validate decommitments: 70.38µs (5.4%) - Validate data size: 391.00ns (0.0%) - Validate Feldmann VSS: 612.57µs (46.8%) - Compute rid: 621.00ns (0.0%) - Compute Ys: 603.55µs (46.1%) - Compute sigma: 581.00ns (0.0%) - Calculate challenge: 19.94µs (1.5%) - Prove knowledge of `sigma_i`: 421.00ns (0.0%) - Unstaged: 261.00ns (0.0%) - Round 5: 267.25µs - Validate schnorr proofs: 265.43µs (99.3%) - Derive resulting public key and other data: 1.34µs (0.5%) - Unstaged: 481.00ns (0.2%) Auxiliary data generation protocol Protocol Performance: - Protocol took 9.53s to complete In particular: - Stage: 10.55µs - Retrieve auxiliary data: 190.00ns (1.8%) - Setup networking: 9.06µs (85.8%) - Precompute execution id and shared state: 1.20µs (11.4%) - Unstaged: 100.00ns (0.9%) - Round 1: 1.16s - Retrieve primes (p and q): 100.00ns (0.0%) - Compute paillier decryption key (N): 6.01µs (0.0%) - Generate auxiliary params r, λ, t, s: 9.36ms (0.8%) - Prove Πprm (ψˆ_i): 1.15s (99.2%) - Sample random bytes: 2.20µs (0.0%) - Compute hash commitment and sample decommitment: 304.82µs (0.0%) - Unstaged: 261.00ns (0.0%) - Round 2: 1.48µs - Hash received msgs (reliability check): 1.09µs (73.7%) - Unstaged: 390.00ns (26.3%) - Round 3: 430.00ns - Assert other parties hashed messages (reliability check): 260.00ns (60.5%) - Unstaged: 170.00ns (39.5%) - Round 4: 5.89s - Validate round 1 decommitments: 600.12µs (0.0%) - Validate П_prm (ψ_i): 2.28s (38.8%) - Add together shared random bytes: 1.98µs (0.0%) - Compute П_mod (ψ_i): 3.44s (58.3%) - Assemble security params for П_fac (ф_i): 6.61µs (0.0%) - Compute П_fac (ф_i^j): 170.94ms (2.9%) - Unstaged: 1.17µs (0.0%) - Round 5: 2.48s - Validate ψ_j (П_mod): 2.31s (93.1%) - Validate ф_j (П_fac): 172.10ms (6.9%) - Assemble auxiliary info: 149.97µs (0.0%) - Unstaged: 2.75µs (0.0%) Signing protocol Protocol Performance: - Protocol took 4.16s to complete In particular: - Stage: 141.43µs - Map t-out-of-n protocol to t-out-of-t: 66.85µs (47.3%) - Retrieve auxiliary data: 68.97µs (48.8%) - Precompute execution id and security params: 772.00ns (0.5%) - Setup networking: 4.75µs (3.4%) - Unstaged: 81.00ns (0.1%) - Round 1: 188.78ms - Generate local ephemeral secrets (k_i, y_i, p_i, v_i): 49.63µs (0.0%) - Encrypt G_i and K_i: 107.32ms (56.8%) - Prove ψ0_j: 81.41ms (43.1%) - Unstaged: 1.60µs (0.0%) - Round 2: 15.54µs - Hash received msgs (reliability check): 15.20µs (97.8%) - Unstaged: 340.00ns (2.2%) - Round 3: 2.23s - Assert other parties hashed messages (reliability check): 1.34µs (0.0%) - Verify psi0 proofs: 268.96ms (12.1%) - Sample random r, hat_r, s, hat_s, beta, hat_beta: 56.60µs (0.0%) - Encrypt D_ji: 70.31ms (3.2%) - Encrypt F_ji: 35.77ms (1.6%) - Encrypt hat_D_ji: 559.38ms (25.1%) - Encrypt hat_F_ji: 35.77ms (1.6%) - Prove psi_ji: 789.78ms (35.5%) - Prove psiˆ_ji: 209.66ms (9.4%) - Prove psi_prime_ji : 257.97ms (11.6%) - Unstaged: 2.35µs (0.0%) - Round 4: 1.56s - Retrieve auxiliary data: 6.18µs (0.0%) - Validate psi: 164.55ms (10.5%) - Validate hat_psi: 164.28ms (10.5%) - Validate psi_prime: 935.21ms (59.9%) - Compute Gamma, Delta_i, delta_i, chi_i: 215.14ms (13.8%) - Prove psi_prime_prime: 81.20ms (5.2%) - Unstaged: 570.00ns (0.0%) - Presig output: 185.01ms - Validate psi_prime_prime: 184.88ms (99.9%) - Calculate presignature: 134.60µs (0.1%) - Unstaged: 873.00ns (0.0%) - Partial signing: 10.21µs - Signature reconstruction: 202.40µs ```
github-actions[bot] commented 4 months ago

The spec was successfully compiled. PDF is available here.