search

dfns / cggmp21

State-of-art threshold ECDSA in Rust
Apache License 2.0
41 stars 6 forks source link

Add `KeyInfo`, redesign `Valid<T>` #80

Closed survived closed 4 months ago

survived commented 4 months ago
github-actions[bot] commented 4 months ago

Benchmark Result

Benchmarks ```text RUST_TESTS_SEED=ebd8267e409a1e23b732bc38b97912f3bf58ca1ccc42e2502622bf4dbcd24a69 n = 3 Non-threshold DKG Protocol Performance: - Protocol took 438.10µs to complete In particular: - Stage: 9.52µs - Setup networking: 9.29µs (97.6%) - Unstaged: 230.00ns (2.4%) - Round 1: 152.66µs - Compute execution id: 9.68µs (6.3%) - Sample x_i, rid_i, chain_code: 67.33µs (44.1%) - Sample schnorr commitment: 59.64µs (39.1%) - Commit to public data: 15.71µs (10.3%) - Unstaged: 311.00ns (0.2%) - Round 2: 2.70µs - Hash received msgs (reliability check): 2.51µs (92.9%) - Unstaged: 190.00ns (7.1%) - Round 3: 281.00ns - Assert other parties hashed messages (reliability check): 160.00ns (56.9%) - Unstaged: 121.00ns (43.1%) - Round 4: 34.74µs - Validate decommitments: 32.93µs (94.8%) - Calculate challege rid: 1.33µs (3.8%) - Prove knowledge of `x_i`: 330.00ns (0.9%) - Unstaged: 150.00ns (0.4%) - Round 5: 238.20µs - Validate schnorr proofs: 237.90µs (99.9%) - Unstaged: 300.00ns (0.1%) Threshold DKG Protocol Performance: - Protocol took 1.32ms to complete In particular: - Stage: 1.84µs - Setup networking: 1.75µs (95.1%) - Unstaged: 90.00ns (4.9%) - Round 1: 271.11µs - Compute execution id: 1.03µs (0.4%) - Sample rid_i, schnorr commitment, polynomial, chain_code: 247.30µs (91.2%) - Commit to public data: 22.57µs (8.3%) - Unstaged: 210.00ns (0.1%) - Round 2: 1.12µs - Hash received msgs (reliability check): 941.00ns (83.9%) - Unstaged: 181.00ns (16.1%) - Round 3: 312.00ns - Assert other parties hashed messages (reliability check): 170.00ns (54.5%) - Unstaged: 142.00ns (45.5%) - Round 4: 778.45µs - Validate decommitments: 43.69µs (5.6%) - Validate data size: 371.00ns (0.0%) - Validate Feldmann VSS: 358.69µs (46.1%) - Compute rid: 210.00ns (0.0%) - Compute Ys: 360.51µs (46.3%) - Compute sigma: 310.00ns (0.0%) - Calculate challenge: 14.39µs (1.8%) - Prove knowledge of `sigma_i`: 140.00ns (0.0%) - Unstaged: 140.00ns (0.0%) - Round 5: 266.35µs - Validate schnorr proofs: 264.84µs (99.4%) - Derive resulting public key and other data: 1.32µs (0.5%) - Unstaged: 190.00ns (0.1%) Auxiliary data generation protocol Protocol Performance: - Protocol took 9.52s to complete In particular: - Stage: 10.87µs - Retrieve auxiliary data: 151.00ns (1.4%) - Setup networking: 9.52µs (87.6%) - Precompute execution id and shared state: 1.14µs (10.5%) - Unstaged: 60.00ns (0.6%) - Round 1: 1.16s - Retrieve primes (p and q): 110.00ns (0.0%) - Compute paillier decryption key (N): 4.45µs (0.0%) - Generate auxiliary params r, λ, t, s: 9.45ms (0.8%) - Prove Πprm (ψˆ_i): 1.15s (99.2%) - Sample random bytes: 2.85µs (0.0%) - Compute hash commitment and sample decommitment: 309.84µs (0.0%) - Unstaged: 220.00ns (0.0%) - Round 2: 1.32µs - Hash received msgs (reliability check): 1.04µs (78.8%) - Unstaged: 281.00ns (21.2%) - Round 3: 450.00ns - Assert other parties hashed messages (reliability check): 250.00ns (55.6%) - Unstaged: 200.00ns (44.4%) - Round 4: 5.88s - Validate round 1 decommitments: 598.46µs (0.0%) - Validate П_prm (ψ_i): 2.28s (38.8%) - Add together shared random bytes: 1.97µs (0.0%) - Compute П_mod (ψ_i): 3.43s (58.3%) - Assemble security params for П_fac (ф_i): 6.28µs (0.0%) - Compute П_fac (ф_i^j): 171.58ms (2.9%) - Unstaged: 1.21µs (0.0%) - Round 5: 2.48s - Validate ψ_j (П_mod): 2.31s (93.0%) - Validate ф_j (П_fac): 172.47ms (7.0%) - Assemble auxiliary info: 150.13µs (0.0%) - Unstaged: 671.00ns (0.0%) Signing protocol Protocol Performance: - Protocol took 4.16s to complete In particular: - Stage: 134.93µs - Map t-out-of-n protocol to t-out-of-t: 64.40µs (47.7%) - Retrieve auxiliary data: 66.53µs (49.3%) - Precompute execution id and security params: 661.00ns (0.5%) - Setup networking: 3.25µs (2.4%) - Unstaged: 90.00ns (0.1%) - Round 1: 188.39ms - Generate local ephemeral secrets (k_i, y_i, p_i, v_i): 49.12µs (0.0%) - Encrypt G_i and K_i: 107.42ms (57.0%) - Prove ψ0_j: 80.92ms (43.0%) - Unstaged: 1.10µs (0.0%) - Round 2: 15.05µs - Hash received msgs (reliability check): 14.83µs (98.5%) - Unstaged: 220.00ns (1.5%) - Round 3: 2.23s - Assert other parties hashed messages (reliability check): 1.11µs (0.0%) - Verify psi0 proofs: 269.59ms (12.1%) - Sample random r, hat_r, s, hat_s, beta, hat_beta: 50.26µs (0.0%) - Encrypt D_ji: 70.20ms (3.1%) - Encrypt F_ji: 35.71ms (1.6%) - Encrypt hat_D_ji: 559.31ms (25.1%) - Encrypt hat_F_ji: 35.71ms (1.6%) - Prove psi_ji: 789.27ms (35.4%) - Prove psiˆ_ji: 211.98ms (9.5%) - Prove psi_prime_ji : 257.32ms (11.5%) - Unstaged: 1.01µs (0.0%) - Round 4: 1.56s - Retrieve auxiliary data: 5.08µs (0.0%) - Validate psi: 164.54ms (10.6%) - Validate hat_psi: 164.12ms (10.5%) - Validate psi_prime: 933.86ms (59.9%) - Compute Gamma, Delta_i, delta_i, chi_i: 215.38ms (13.8%) - Prove psi_prime_prime: 81.28ms (5.2%) - Unstaged: 703.00ns (0.0%) - Presig output: 184.79ms - Validate psi_prime_prime: 184.66ms (99.9%) - Calculate presignature: 134.91µs (0.1%) - Unstaged: 881.00ns (0.0%) - Partial signing: 9.88µs - Signature reconstruction: 201.34µs ```
github-actions[bot] commented 4 months ago

The spec was successfully compiled. PDF is available here.

github-actions[bot] commented 4 months ago

Crate direct deps

Direct deps ```text cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen) digest v0.10.6 futures v0.3.24 generic-ec v0.1.3 generic-ec-zkp v0.1.1 hex v0.4.3 paillier-zk v0.1.0 rand_chacha v0.3.1 rand_core v0.6.4 round-based v0.2.0 serde v1.0.188 serde_with v2.3.3 sha2 v0.10.6 thiserror v1.0.48 udigest v0.1.0 ```

Compared to base branch

Diff ```text --- direct-deps-base 2024-02-22 08:01:53.546411674 +0000 +++ direct-deps-pr 2024-02-22 08:01:53.822413570 +0000 @@ -1 +1 @@ -cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen) +cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen) ```

All deps

cargo tree ```text cggmp21 v0.2.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21) ├── cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen) │ ├── digest v0.10.6 │ │ ├── block-buffer v0.10.3 │ │ │ └── generic-array v0.14.6 │ │ │ ├── serde v1.0.188 │ │ │ │ └── serde_derive v1.0.188 (proc-macro) │ │ │ │ ├── proc-macro2 v1.0.66 │ │ │ │ │ └── unicode-ident v1.0.4 │ │ │ │ ├── quote v1.0.33 │ │ │ │ │ └── proc-macro2 v1.0.66 (*) │ │ │ │ └── syn v2.0.32 │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── unicode-ident v1.0.4 │ │ │ └── typenum v1.15.0 │ │ └── crypto-common v0.1.6 │ │ ├── generic-array v0.14.6 (*) │ │ └── typenum v1.15.0 │ ├── futures v0.3.24 │ │ ├── futures-channel v0.3.24 │ │ │ ├── futures-core v0.3.24 │ │ │ └── futures-sink v0.3.24 │ │ ├── futures-core v0.3.24 │ │ ├── futures-executor v0.3.24 │ │ │ ├── futures-core v0.3.24 │ │ │ ├── futures-task v0.3.24 │ │ │ └── futures-util v0.3.24 │ │ │ ├── futures-channel v0.3.24 (*) │ │ │ ├── futures-core v0.3.24 │ │ │ ├── futures-io v0.3.24 │ │ │ ├── futures-macro v0.3.24 (proc-macro) │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── syn v1.0.101 │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── unicode-ident v1.0.4 │ │ │ ├── futures-sink v0.3.24 │ │ │ ├── futures-task v0.3.24 │ │ │ ├── memchr v2.5.0 │ │ │ ├── pin-project-lite v0.2.9 │ │ │ ├── pin-utils v0.1.0 │ │ │ └── slab v0.4.7 │ │ ├── futures-io v0.3.24 │ │ ├── futures-sink v0.3.24 │ │ ├── futures-task v0.3.24 │ │ └── futures-util v0.3.24 (*) │ ├── generic-ec v0.1.3 │ │ ├── generic-ec-core v0.1.2 │ │ │ ├── generic-array v0.14.6 (*) │ │ │ ├── rand_core v0.6.4 │ │ │ ├── serde v1.0.188 (*) │ │ │ ├── subtle v2.4.1 │ │ │ └── zeroize v1.6.0 │ │ │ └── zeroize_derive v1.3.2 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ ├── syn v1.0.101 (*) │ │ │ └── synstructure v0.12.6 │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ ├── syn v1.0.101 (*) │ │ │ └── unicode-xid v0.2.4 │ │ ├── getrandom v0.2.10 │ │ │ ├── cfg-if v1.0.0 │ │ │ └── libc v0.2.148 │ │ ├── hex v0.4.3 │ │ │ └── serde v1.0.188 (*) │ │ ├── phantom-type v0.4.2 │ │ │ └── educe v0.4.19 (proc-macro) │ │ │ ├── enum-ordinalize v3.1.11 (proc-macro) │ │ │ │ ├── num-bigint v0.4.3 │ │ │ │ │ ├── num-integer v0.1.45 │ │ │ │ │ │ └── num-traits v0.2.15 │ │ │ │ │ └── num-traits v0.2.15 │ │ │ │ ├── num-traits v0.2.15 │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── syn v1.0.101 (*) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v1.0.101 (*) │ │ ├── rand_core v0.6.4 │ │ ├── serde v1.0.188 (*) │ │ ├── serde_with v2.3.3 │ │ │ ├── serde v1.0.188 (*) │ │ │ └── serde_with_macros v2.3.3 (proc-macro) │ │ │ ├── darling v0.20.1 │ │ │ │ ├── darling_core v0.20.1 │ │ │ │ │ ├── fnv v1.0.7 │ │ │ │ │ ├── ident_case v1.0.1 │ │ │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ │ ├── strsim v0.10.0 │ │ │ │ │ └── syn v2.0.32 (*) │ │ │ │ └── darling_macro v0.20.1 (proc-macro) │ │ │ │ ├── darling_core v0.20.1 (*) │ │ │ │ ├── quote v1.0.33 (*) │ │ │ │ └── syn v2.0.32 (*) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v2.0.32 (*) │ │ ├── subtle v2.4.1 │ │ ├── udigest v0.1.0 │ │ │ ├── digest v0.10.6 (*) │ │ │ └── udigest-derive v0.1.0 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v2.0.32 (*) │ │ └── zeroize v1.6.0 (*) │ ├── generic-ec-zkp v0.1.1 │ │ ├── generic-array v0.14.6 (*) │ │ ├── generic-ec v0.1.3 (*) │ │ ├── rand_core v0.6.4 │ │ ├── serde v1.0.188 (*) │ │ ├── subtle v2.4.1 │ │ └── udigest v0.1.0 (*) │ ├── hex v0.4.3 (*) │ ├── key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) │ │ ├── generic-ec v0.1.3 (*) │ │ ├── generic-ec-zkp v0.1.1 (*) │ │ ├── hex v0.4.3 (*) │ │ ├── serde v1.0.188 (*) │ │ ├── serde_with v2.3.3 (*) │ │ └── thiserror v1.0.48 │ │ └── thiserror-impl v1.0.48 (proc-macro) │ │ ├── proc-macro2 v1.0.66 (*) │ │ ├── quote v1.0.33 (*) │ │ └── syn v2.0.32 (*) │ ├── rand_core v0.6.4 │ ├── round-based v0.2.0 │ │ ├── futures-util v0.3.24 (*) │ │ ├── phantom-type v0.3.1 │ │ │ └── educe v0.4.19 (proc-macro) (*) │ │ ├── round-based-derive v0.2.0 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v1.0.101 (*) │ │ ├── thiserror v1.0.48 (*) │ │ └── tracing v0.1.36 │ │ ├── cfg-if v1.0.0 │ │ ├── pin-project-lite v0.2.9 │ │ ├── tracing-attributes v0.1.22 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v1.0.101 (*) │ │ └── tracing-core v0.1.29 │ │ └── once_cell v1.17.0 │ ├── serde v1.0.188 (*) │ ├── serde_with v2.3.3 (*) │ ├── sha2 v0.10.6 │ │ ├── cfg-if v1.0.0 │ │ ├── cpufeatures v0.2.5 │ │ └── digest v0.10.6 (*) │ ├── thiserror v1.0.48 (*) │ └── udigest v0.1.0 (*) ├── digest v0.10.6 (*) ├── futures v0.3.24 (*) ├── generic-ec v0.1.3 (*) ├── generic-ec-zkp v0.1.1 (*) ├── hex v0.4.3 (*) ├── paillier-zk v0.1.0 │ ├── digest v0.10.6 (*) │ ├── fast-paillier v0.1.0 │ │ ├── bytemuck v1.13.1 │ │ │ └── bytemuck_derive v1.4.1 (proc-macro) │ │ │ ├── proc-macro2 v1.0.66 (*) │ │ │ ├── quote v1.0.33 (*) │ │ │ └── syn v2.0.32 (*) │ │ ├── rand_core v0.6.4 │ │ ├── rug v1.21.0 │ │ │ ├── az v1.2.1 │ │ │ ├── gmp-mpfr-sys v1.6.1 │ │ │ │ └── libc v0.2.148 │ │ │ ├── libc v0.2.148 │ │ │ └── serde v1.0.188 (*) │ │ ├── serde v1.0.188 (*) │ │ └── thiserror v1.0.48 (*) │ ├── generic-ec v0.1.3 (*) │ ├── rand_core v0.6.4 │ ├── rug v1.21.0 (*) │ ├── serde v1.0.188 (*) │ ├── serde_with v3.0.0 │ │ ├── serde v1.0.188 (*) │ │ └── serde_with_macros v3.0.0 (proc-macro) │ │ ├── darling v0.20.1 (*) │ │ ├── proc-macro2 v1.0.66 (*) │ │ ├── quote v1.0.33 (*) │ │ └── syn v2.0.32 (*) │ └── thiserror v1.0.48 (*) ├── rand_chacha v0.3.1 │ ├── ppv-lite86 v0.2.17 │ └── rand_core v0.6.4 ├── rand_core v0.6.4 ├── round-based v0.2.0 (*) ├── serde v1.0.188 (*) ├── serde_with v2.3.3 (*) ├── sha2 v0.10.6 (*) ├── thiserror v1.0.48 (*) └── udigest v0.1.0 (*) ```

Compared to base branch

Diff ```text --- all-deps-base 2024-02-22 08:01:53.678412581 +0000 +++ all-deps-pr 2024-02-22 08:01:53.954414139 +0000 @@ -6 +6 @@ -cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen) +cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen) @@ -34 +34 @@ -key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share) +key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) ```
maurges commented 4 months ago

Trying this for my branch: we should now make AnyKeyShare::core give Valid<CoreShare> instead of DirtyCoreShare. Though I can do it myself. Another pain point: there's no AsRef<T> for T, so I still have to clone

survived commented 4 months ago

Another pain point: there's no AsRef for T, so I still have to clone

You need to manually implement it for each T, it's a bit more code, but it's common practice with AsRef trait

we should now make AnyKeyShare::core

I actually have feeling that we probably don't need AnyKeyShare anymore, impl AsRef<CoreKeyShare> should pretty much replace it.