Refactor, Test and Validate Commercial Salmon Catch Query

[Br-Johnson]

• [ ] Understand what updates/changes Sherry has made and determine best means to capitalize on hours already put into this query...
• [ ] Refactor query, possibly in SQL or Rspark
• [ ] Develop battery of tests to ensure SQL query translation occurred correctly and didn't mis match data

[Br-Johnson]

From Sherry: Hi Brett, we've been using your table qry_commercial_catch for one of our dashboards, and I noticed that when I was looking at distinct management areas, that the data is missing some. This is the result that I would get:

I spoke to Jason Parsley about it, and he sent me this document for the results that show up for his at his end, and suggested that his query might be filtering for a specific year, and the sql codes may have only pulled the areas that were active in the original query. I think Joey may have been right about the code all along.

Please let me know if you end up making changes to the qry_commercial_catch table, or if you need any help. Thanks! https://086gc.sharepoint.com/:x:/r/sites/Fishery-Assessment_Data_Section-DataStewardshipUnit2/Shared%20Documents/Data%20Stewardship%20Unit/FOS%20Dashboard/[Fishry_Area_Tbl_Export.xlsx](https://086gc.sharepoint.com/:x:/r/sites/Fishery-Assessment_Data_Section-DataStewardshipUnit2/Shared%20Documents/Data%20Stewardship%20Unit/FOS%20Dashboard/Fishry_Area_Tbl_Export.xlsx?d=w5132d57d1ea7460a9f6ad7fdc4fe68fc&csf=1&web=1&e=orldRK)?d=w5132d57d1ea7460a9f6ad7fdc4fe68fc&csf=1&web=1&e=orldRK

[Br-Johnson]

To save time and effort, maybe the script should not be entirely re-written in a new language, but just tuned for user requirements.

[Br-Johnson]

Sherry Luo will be refactoring the script