search

dfoderick / money-button-donate

Customizable donation amount for the Money Button
MIT License
3 stars 0 forks source link

Unmasked code can be copied by inspecting the html element bypassing payments. #1

Closed shravan-shandilya closed 6 years ago

shravan-shandilya commented 6 years ago

I'm not sure if the intent was to sell the customized code or not. The custom code can be copied directly by inspecting element using browser's developer tools.

If you already knew this and masking/unmasking was just to demonstrate the features that can be built, please ignore.

dfoderick commented 6 years ago

Thanks!

Yes. That feature is just to demonstrate moneybutton as a paywall. I realize that a proper implementation would have to do a better job of obscuring DOM elements.

On Wed, Oct 10, 2018 at 9:11 AM Shravan Shandilya notifications@github.com wrote:

I'm not sure if the intent was to sell the customized code or not. The custom code can be copied directly by inspecting element using browser's developer tools.

If you already knew this and masking/unmasking was just to demonstrate the features that can be built, please ignore.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dfoderick/money-button-donate/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmLA6bpAghwjQ7bV3ZsM-yAeY8C3Bu5ks5ujhxGgaJpZM4XVruX .

--

-Dave

shravan-shandilya commented 6 years ago

Cool. This could be a great usecase once properly done. Closing the issue for now.