dforce-network / dToken

dForce yield token
MIT License
30 stars 10 forks source link

Order of arguments in NewDispatcher event is backwards #27

Closed mgcolburn closed 4 years ago

mgcolburn commented 4 years ago

Severity: Code Quality

Description

The convention followed in the rest of the system is event VarChanged(var oldVal, var newVal) but when updating the dispatcher, the values are reversed: event NewDispatcher(address Dispatcher, address oldDispatcher);

Donald-Nobel commented 4 years ago

Will unify the naming.