search

dfrankland / hyper-tab-icons

💅 Icons in the header tabs for the current running process in Hyper.app.
91 stars 16 forks source link

Cannot find module React #14

Closed roccomuso closed 7 years ago

roccomuso commented 7 years ago

I've added hyperterm-tab-icons or hyper-tab-icons to the plugins. And i got this error:

failed to load (Cannot find module 'React')

dfrankland commented 7 years ago

What version of Hyper.app are you using and what version of hyper-tab-icons are you using?

anirudhb commented 7 years ago

I've got the same error

anirudhb commented 7 years ago

Hyper 0.8.3 and git-HEAD version of hyper-tab-icons.

anirudhb commented 7 years ago

Just found a way to suppress the error: npm install react in .hyper_plugins and in index.js, change the capital R in require("React") to a lowercase R. A white icon shows up, at least.

anirudhb commented 7 years ago

Oh! I'm using hyperterm-mactabs which makes the icon invisible. I removed it, and IT WORKS! I might submit a pull request to invert white if using hyperterm-mactabs.

anirudhb commented 7 years ago

Yes! I figured out how to make it work with hyperterm-mactabs! 🎉

anirudhb commented 7 years ago

Fixing some bugs... 😅

dfrankland commented 7 years ago

Just found a way to suppress the error: npm install react in .hyper_plugins and in index.js, change the capital R in require("React") to a lowercase R. A white icon shows up, at least.

Good catch, I will update this ASAP.

dfrankland commented 7 years ago

Should be fixed with this release: https://github.com/dfrankland/hyper-tab-icons/releases/tag/v1.1.2

Would y'all, @roccomuso & @anirudhb, be able to test?

anirudhb commented 7 years ago

I already did that patch on my local machine (and a few others) and I can say, 👍

anirudhb commented 7 years ago

Just redownloaded

anirudhb commented 7 years ago

👍