search

dfrankland / hyper-tab-icons

💅 Icons in the header tabs for the current running process in Hyper.app.
91 stars 16 forks source link

mapIcons mappings don't apply colors from mapColors #20

Closed mattdarveniza closed 7 years ago

mattdarveniza commented 7 years ago

I've got a mapIcon config that maps a few python-based commands (pyramid specifically) to the python icon, however I've noticed that this mapping doesn't pick up the color specified for the python color mapping. For example:

{
  mapColors: {
    python: 'hsl(39, 67%, 69%)',
  },
  mapIcons: {
    python: ['pserve']
  }
}

This config will apply the icon, but not the color to any pserve commands. Putting pserve into the mapColors config fixes, but it would be nice if it picked up the base icon's color if no custom one was specified.

dfrankland commented 7 years ago

Sorry about this issue. This should be fixed in hyper-tab-icons@1.1.5 with this commit: https://github.com/dfrankland/hyper-tab-icons/commit/649c4092be538aad0a41e8f9d0def69126b776dc