search

dfrankland / hyper-tab-icons

💅 Icons in the header tabs for the current running process in Hyper.app.
91 stars 16 forks source link

Load config Regex issue. #31

Closed LikeSundayLikeRain closed 6 years ago

LikeSundayLikeRain commented 7 years ago

https://github.com/dfrankland/hyper-tab-icons/blob/ef444af2624ba6b22d5afcd8f8fbc8a69f6b1757/src/lib/getIcon.js#L40-L41

Seems it should be config.processNameRegex.source and config.processNameRegex.flags

dfrankland commented 7 years ago

Thanks for the heads up! I just pushed your fix and made a new release for this. Mind testing it out?

LikeSundayLikeRain commented 7 years ago

It's got fixed. But I think I got an another issue.

My custom Regexp defined at config file can't get loaded when I'm launching Hyper, but it works fine when I reload Hyper after it launches.

Looks like Hyper is rendering the plugins before the window loads. So when initiating hyper-tab-icons, const config = getConfig() seems load nothing because of window is not defined.

I'm using Hyper 1.4.8 on a Windows machine, not sure if Hyper loads plugin differently on other systems.

dfrankland commented 7 years ago

Gotcha. I'll take a look into this. I'll have to add back the decorateConfig export and find a nice, functional, way to get the config.

dfrankland commented 6 years ago

Please re-open if this is still an issue with Hyper 2.