search

dfrankland / hyper-tab-icons

💅 Icons in the header tabs for the current running process in Hyper.app.
91 stars 16 forks source link

Suggest using npm cube icon instead of current logo #34

Open sangdth opened 7 years ago

sangdth commented 7 years ago

The npm logo is current used is so small, as the title bar is not good place to use it. So IMHO, we should use the cube icon for better result.

Even npm use the cube icon in their home page when they need.

I tried to apply in this demo so you can see how it displayed:

Demo

Source: SVG cube icon of npm: https://cldup.com/Rg6WLgqccB.svg

Best regards,

sangdth commented 7 years ago

Btw, I don't know how to start working on this despite I really want to. Could somebody help me out? Something like, where should I start? Which document I should read first? What language or knowledge I should learn first? I can self-study, but I really need help to kick-start.

I checked the source code, and saw that there are many React createElement('path', {...}), I think that your code takes the svg files and "translate" them into code?

dfrankland commented 7 years ago

  1. Drop the SVG inside of src/icons/ and add the following to src/icons/index.js:

    export icon from './icon.svg';

    icon should be the name of the SVG file you put in src/icons/.

  2. Add the appropriately mapped color to src/constants/mapColors.js

sangdth commented 7 years ago

Hi @dfrankland , thanks.