search

dfrankland / pokemonsay

👾 Pokemon version of cowsay with CLI and API.
https://www.npmjs.com/package/pokemonsay
MIT License
404 stars 17 forks source link

Could you generate .cow files from the png images and your script? #40

Closed Naereen closed 3 years ago

Naereen commented 3 years ago

Hi again, I thought your implementation used .cow files, like the original one, but I see that there are just PNG images in your version.

(The first issue with that is that it clearly violates Nintendo's copyright, but well.. your project is not the only one.)

On the other hand, I see that the output of your script looks very much like the original project, and I guess the script automatically converts the selected pokemon PNG image to an ASCII version. By using the script, and maybe processing its output a little bit, I guess/hope that it shouldn't be hard to produce .cow files for each Pokémons.

It could be added in a cow/ folder. And without changing anything else in your codebase (no need to use the .cow files, if the current process already works fine), they could be used in the original project code too (I have to admit, I don't want to install a second pokemonsay)

dfrankland commented 3 years ago

Feel free to make a PR

Naereen commented 3 years ago

Sorry I was not saying "can I ..." but "could you .. ?", I won't have time to try this.

dfrankland commented 3 years ago

Sorry, I don't have time either