search

dfrankland / pokemonsay

👾 Pokemon version of cowsay with CLI and API.
https://www.npmjs.com/package/pokemonsay
MIT License
404 stars 17 forks source link

Add a license? #41

Closed Naereen closed 3 years ago

Naereen commented 3 years ago

Hello there, I see your project does not have a LICENSE file, and as such it means that it is not open-source, but fully copyrighted to you. Could I suggest that you try to choose an open-source license, and add it? The choosealicense.com/ can help you do that. Don't hesitate to ask questions, if you want. Regards

dfrankland commented 3 years ago

MIT https://github.com/dfrankland/pokemonsay/blob/347876c14043a7f42b03c7511a844c96fa57a1ac/package.json#L18

I'll add a license file soon

Naereen commented 3 years ago

Thanks. Add a LICENSE file would allow GitHub to display it nicely (on the right of the new web interface), and adding a mention on the README would also help.

Naereen commented 3 years ago

@dfrankland still no LICENSE file and no mention on the README?

dfrankland commented 3 years ago

@Naereen I am open to pull requests

Naereen commented 3 years ago

Of course you are, but that's quite lazy. Honestly? You expect a PR just to add a single file?

Naereen commented 3 years ago

... done.