search

dfranx / ImFileDialog

A file dialog library for Dear ImGui
MIT License
495 stars 57 forks source link

Fixes to compile with dear imgui 1.80 + warning fixes. #1

Closed ocornut closed 3 years ago

ocornut commented 3 years ago

Minor fixes (your code previously used alpha table api some of which had changed)

Also note that for right/bottom align -FLT_MIN is more correct than -1.0f which will remove an extra pixel) hence those changes.

Note that I didn't yet run ImFileDialog, this is merely putting some fixes out ahead for users who will try to use it with dear imgui master. I'm also getting two std::string related warning I haven't inspected yet.

ocornut commented 3 years ago

Now ran it and force-pushed some fixes for column policy.

Since there are 3 columns and the intent seems to have 2 of them not resizable it's not meaningful to set the ImGuiTableFlags_Resizable flag, but it could be brought back if removing ImGuiTableColumnFlags_NoResize from the secondary columns.

dfranx commented 3 years ago

Thanks for the PR, merged! And thank you for the tips, will keep them in mind!

SadE54 commented 2 years ago

LastitemRect was removed from imgui_internal.h in 1.84 :-/ Is it possible to add a commit to get the file dialog working with 1.84+ please ?

ocornut commented 2 years ago

See https://github.com/ocornut/imgui/discussions/4526#discussioncomment-1308122