dfranx / SPIRV-VM

Virtual machine for executing SPIR-V
MIT License
294 stars 27 forks source link

Improve image sampling implementation #9

Closed nyorain closed 2 years ago

nyorain commented 3 years ago

This implements a new API for image sampling with the following goals:

More of a RFC on the API design for now, the implementation still has some TODOs, isn't well tested and I might have missed one or two changes from my modified spvm version that are already needed. I would be in favor of adding a small set of unit tests to spvm and be willing to write them.

This PR already contains some additional fixes that were needed/useful to implement the new sampling:

dfranx commented 2 years ago

Thank you so much for the PR. I've tested it a bit and it works nicely. I am going to give it a more thorough test once I integrate this new version of SPIRV-VM into SHADERed.

I am open to unit tests too -- it would certainly improve the quality of the project!

Anyway, it's a really nice PR, thank you once again. I've added you to the README.md as a contributor.