search

dfreeman / ember-cli-node-assets

Include stylesheets, images and other assets in your Ember app from node modules
MIT License
62 stars 6 forks source link

Support import sourcemap file? #5

Closed nightire closed 7 years ago

nightire commented 7 years ago

Document says this is possible, but seems it will be omitted and never get any chance to import:

https://github.com/dfreeman/ember-cli-node-assets/blob/bb540165ebbbd3d280437148e09a94907ad41a10/index.js#L24

So does it still be supported or a future-possible feature?

dfreeman commented 7 years ago

Looks like this got lost in a bad merge here. Sorry about that!

I just pushed a commit that should take care of the issue, and I'll publish a new release shortly. I also filed an issue as a reminder to myself to get better unit testing in place so this kind of thing doesn't regress in the future!

nightire commented 7 years ago

Awesome, thank you very much!

XaserAcheron commented 7 years ago

This likely isn't the greatest place to ask, but it's relevant, so:

How do you exactly use this feature? It's not in the docs and I'm having trouble figuring it out myself.

dfreeman commented 7 years ago

@XaserAcheron with the 0.2.x series of releases, you no longer need to do anything special for sourcemaps. As long as your funnel configuration for a given package doesn't exclude the sourcemap file, Ember CLI should pick it up when it concatenates together the files you've imported.

XaserAcheron commented 7 years ago

I'm getting ENOENT: no such file or directory warnings for sourcemaps for a couple of (non-Ember) imports. I'll try and post more details when I'm back at it tomorrow-ish.

[EDIT] Well, I suppose a closed issue thread really isn't the best place for this at all. Welp.

dfreeman commented 7 years ago

[EDIT] Well, I suppose a closed issue thread really isn't the best place for this at all. Welp.

Haha, I've seen worse abuse of old issue threads. Feel free to ping me on the Ember Slack tomorrow (I'm @dfreeman there too) with more details if you want, and I can try to help you debug what's going on 🙂