search

dfreeman / ember-workspace-playground

0 stars 1 forks source link

compatibility with ember-decorators #1

Open theseyi opened 5 years ago

theseyi commented 5 years ago

I tried adding ember decorators to the addon using the following steps and then running ember test:

 git clone https://github.com/dfreeman/ember-workspace-playground.git
 yarn
cd addon-a
ember install ember-decorators --save
./node_modules/.bin/ember test

output:

➜  addon-a git:(master) ✗ ./node_modules/.bin/ember test
Environment: test
cleaning up...
Build Error (broccoli-persistent-filter:Babel > [Babel: addon-a]) in dummy/addon-a/tests/addon.lint-test.js

The 'decorators' plugin requires a 'decoratorsBeforeExport' option, whose value must be a boolean. If you are migrating from Babylon/Babel 6 or want to use the old decorators proposal, you should use the 'decorators-legacy' plugin instead of 'decorators'.

Stack Trace and Error Report: /var/folders/wg/5pdyslhx5zz9n97j4q334_6w000p7_/T/error.dump.c31eafb6c532998ef878ba9d3e3fad2b.log

Am I missing something in these steps? @dfreeman thanks

dfreeman commented 5 years ago

🤔 I'd file an issue over on the ember-decorators repo, I think. The ember-cli-typescript v2 beta doesn't add a decorators transform itself, so whatever's going on is likely stemming from there.