➡️ Need to take offset into account when calculating draw area

[Jasper-Bekkers]

There was a small artifact noticeable when offset wasn't taken into account when calculating the bounds of the rectangle, leading to 1px clipping artifacts.

This would break in cosmic-text where the offset would be used to offset the glyph with a tiny fractional amount, causing incorrect rounding in this routine as a result.

https://github.com/pop-os/cosmic-text/blob/2342bf0eaebe6d41661b1fb49ed30d4021a9807d/src/swash.rs#L33-L35

Current main branch;

With this fix applied;

Notice some instances of the 💩 , 🐭and more subtly the top of the 🤖 emoji.

[Jasper-Bekkers]

@dfrg This is a relatively small change leading to much nicer visual representation (and I think it's correct?) Could you double check?

[dfrg]

This looks reasonable to me. Thanks!

Also, please feel free to @ me in future PRs. I don’t check this project much and I’m bombarded with GH notifications so I tend to miss things.

[Jasper-Bekkers]

@dfrg Thanks! Could you push a new (patch) release?

[dfrg]

Certainly! I’ll try to get to it later this evening.

[dfrg]

Published 0.1.6!