search

dfridrich / Ares

Communication with ARES (Czech business register)
MIT License
26 stars 27 forks source link

Allow to use string company identification number + fix and refactor its testcases #26

Closed filipmelik closed 2 years ago

filipmelik commented 5 years ago

Hello, I made some refactoring and cleanup in the Ares class. Also I fixed failing test (due to non-existent VAT ID in tested subject) and refactored all test cases for findByIdentificationNumber to single test cases that is parametrized via dataprovider function.

Also I've allowed findByIdentificationNumber to accept identification number either in string format or integer format instead of just integer format (since company identification number can start with leading zeros)