dfskoll / rp-pppoe

Public repository for RP-PPPoE PPPoE client and server software
https://dianne.skoll.ca/projects/rp-pppoe/
47 stars 15 forks source link

fix krn plugin #5

Closed ffontaine closed 2 years ago

ffontaine commented 2 years ago

This patch has been added to buildroot more than eleven years ago with https://git.buildroot.net/buildroot/commit/?id=e9ae739ce757d73657ef860e21ccc78b3d55816e

[Retrieved from: https://git.buildroot.net/buildroot/tree/package/rp-pppoe/0001-krn-plugin.patch] Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

ffontaine commented 2 years ago

I would like to get your feedback on this pretty old patch that we're carrying on buildroot side. If I remove it, rp-pppoe seems to build perfectly fine nowadays. Do you think that we can safely remove it?

dfskoll commented 2 years ago

Hi,

Sorry; I missed your original message. If rp-pppoe cross-compiles and works with kernel-mode PPPoE, then I think you can drop the patch.

Regards,

Dianne.

ffontaine commented 2 years ago

Thanks Diane, I'll check on buildroot side if we can drop this patch. Depending on their feedback, I'll close this PR or update it to take into account your comments.

Best Regards

ffontaine commented 2 years ago

I'm closing this PR, patch has been removed from buildroot: