search

dftd3 / simple-dftd3

reimplementation of the DFT-D3 program
https://dftd3.readthedocs.io
GNU Lesser General Public License v3.0
51 stars 24 forks source link

cmake looks for mstore but binaries aren't linked with it #11

Closed yurivict closed 2 years ago

yurivict commented 2 years ago

mstore's executables also aren't used. Is this an unnecessary check in cmake?

awvwgk commented 2 years ago

mstore is not supposed to be linked in any final library. It only serves the data required for running the unit tests and is linked with the test driver:

https://github.com/awvwgk/simple-dftd3/blob/a9e8051c186e07de323620a2b42c134dc4a4faf1/test/unit/CMakeLists.txt#L37-L46

Think of it as development or build dependency rather than a proper dependency. However, unless CMake can find an external dependency, it will build mstore on demand and also install it, because this behavior turns out be quite hard to disable with CMake.

yurivict commented 2 years ago

Thank you.